Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pulsar (ticdc): fix some pulsar sink related error #9657

Merged
merged 11 commits into from
Sep 8, 2023

Conversation

asddongmen
Copy link
Contributor

@asddongmen asddongmen commented Aug 30, 2023

What problem does this PR solve?

Issue Number: ref #9413

What is changed and how it works?

Fix some pulsar sink error that I encountered in testing.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Questions

Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?

Release note

None

@ti-chi-bot ti-chi-bot bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Aug 30, 2023
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Aug 30, 2023
@asddongmen asddongmen changed the title pulsar (ticdc): fix some error pulsar (ticdc): fix some pulsar sink related error Aug 30, 2023
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Aug 30, 2023
pkg/config/sink.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 7, 2023
pkg/config/sink.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 7, 2023
pkg/config/sink.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 7, 2023
@asddongmen
Copy link
Contributor Author

/retest

1 similar comment
@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 7, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CharlesCheung96, sdojjy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [CharlesCheung96,sdojjy]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 7, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 7, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-09-07 06:48:33.074089996 +0000 UTC m=+2600877.623105981: ☑️ agreed by sdojjy.
  • 2023-09-07 11:34:49.183431666 +0000 UTC m=+2618053.732447637: ☑️ agreed by CharlesCheung96.

@asddongmen
Copy link
Contributor Author

/retest

1 similar comment
@asddongmen
Copy link
Contributor Author

/retest

@ti-chi-bot ti-chi-bot bot merged commit b9a647d into pingcap:master Sep 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants