-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kv(ticdc): Remove store connect backoff #9740
kv(ticdc): Remove store connect backoff #9740
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hicqu, nongfushanquan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
) | ||
} | ||
if c.config.Debug.EnableKVConnectBackOff { | ||
newStreamErr = retry.Do(ctx, streamFunc, retry.WithBackoffBaseDelay(500), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
newStreamErr = retry.Do(ctx, streamFunc, retry.WithBackoffBaseDelay(500), | |
newStreamErr = retry.Do(ctx, streamFunc, retry.WithBackoffBaseDelay(100), |
What problem does this PR solve?
Issue Number: close #9741
What is changed and how it works?
remove the kv connect backoff logic by default.
6 tikv nodes with about 20k regions, the LAG before this PR is about 6min
after this PR , the LAG is about 40s
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
Do you need to update user documentation, design documentation or monitoring documentation?
Release note