Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: add resource group tag definition #223

Merged
merged 3 commits into from
May 25, 2021
Merged

*: add resource group tag definition #223

merged 3 commits into from
May 25, 2021

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented May 20, 2021 •
edited
Loading

Signed-off-by: crazycs [email protected]

Add following definition:

message ResourceGroupTag {
	optional bytes sql_digest = 1;
	optional bytes plan_digest = 2;
}

This is use for TOP SQL.

@crazycs520
add resource group tag
7795002 
Signed-off-by: crazycs <[email protected]>
@CLAassistant
Copy link

CLAassistant commented May 20, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@crazycs520
fix typo
2b3fd46 
Signed-off-by: crazycs <[email protected]>
breezewish
breezewish reviewed May 21, 2021
View reviewed changes
proto/trace.proto Outdated Show resolved Hide resolved
@crazycs520
address comment
3396891 
Signed-off-by: crazycs <[email protected]>
@crazycs520 crazycs520 mentioned this pull request May 24, 2021
Merged
@crazycs520 crazycs520 merged commit b80be13 into pingcap:master May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breezewish breezewish breezewish approved these changes

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @CLAassistant @lysu @breezewish