Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tiflash pipeline wait summary and minTSO wait time in execution summary #346

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

yibin87
Copy link
Contributor

@yibin87 yibin87 commented Oct 22, 2024

What problem does this PR solve?

Issue Number: ref pingcap/tiflash#9489

Problem Summary:

What is changed and how it works?

Proposal: xxx

What's Changed:

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

@yibin87 yibin87 changed the title Add tiflash pipeline wait summary in execution summary Add tiflash pipeline wait summary and minTSO wait info in execution summary Oct 22, 2024
@yibin87 yibin87 changed the title Add tiflash pipeline wait summary and minTSO wait info in execution summary Add tiflash pipeline wait summary and minTSO wait time in execution summary Oct 22, 2024
@@ -375,6 +381,10 @@ message TiFlashScanContext {
optional uint64 total_vector_idx_read_others_time_ms = 108;
}

message TiFlashPipelineWaitSummary {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename this to TiFlashWaitSummary and put all the tiflash wait info into it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, addressed

Signed-off-by: yibin <[email protected]>
Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yibin87 yibin87 merged commit 0607513 into pingcap:master Oct 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants