-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
*: reduce memory allocation for plenty of idle connections #474
Conversation
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xhebox The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #474 +/- ##
=======================================
Coverage ? 64.25%
=======================================
Files ? 61
Lines ? 5698
Branches ? 0
=======================================
Hits ? 3661
Misses ? 1752
Partials ? 285
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
What problem does this PR solve?
Issue Number: close #472
Problem Summary:
When there are many idle connections on a TiProxy instance, the CPU usage jitters every 2 minutes because of GC.
What is changed and how it works:
time.After
totime.Ticker
sync.Map
withmap
andsync.Lock
header
,salt
Check List
Tests
Run and profile to see the frame graph and the overhead disappears.
alloc_objects:
inuse_objects:
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.