Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backend: remove support for protocol_41 #49

Merged
merged 2 commits into from
Aug 20, 2022
Merged

backend: remove support for protocol_41 #49

merged 2 commits into from
Aug 20, 2022

Conversation

djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Aug 19, 2022 •
edited by xhebox
Loading

What problem does this PR solve?

Issue Number: close #48

Problem Summary:
Since pingcap/tidb#27768 has removed the old handshake support, the proxy doesn't need to support it.

What is changed and how it works:

  • remove support other than protocol_41.
  • fix unstable test TestNetworkError.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change (Don't forget to add the declarative for API)
  • Has weirctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@djshow832 djshow832 requested a review from xhebox August 19, 2022 13:37
@xhebox xhebox merged commit c5b871a into pingcap:main Aug 20, 2022
@djshow832 djshow832 deleted the protocol_41 branch August 21, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xhebox xhebox xhebox approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove old handshake support
2 participants
@djshow832 @xhebox