Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security: add unit test for cert pool #496

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

djshow832
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #464

Problem Summary:
It proves that a cert pool can store multiple CAs and each CA works. It's useful for the design of cert-based auth.
E.g. there are 2 certs: ca1 + cert1 + key1 and ca2 + cert2 + key2
If I put both ca1 and ca2 into the cert pool, the cert pool can verify both cert1 + key1 and cert2 + key2.

What is changed and how it works:
Add a unit test.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot requested review from bb7133 and xhebox March 28, 2024 07:32
@ti-chi-bot ti-chi-bot bot added the size/L label Mar 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (main@b543b47). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #496   +/-   ##
=======================================
  Coverage        ?   64.77%           
=======================================
  Files           ?       61           
  Lines           ?     5814           
  Branches        ?        0           
=======================================
  Hits            ?     3766           
  Misses          ?     1755           
  Partials        ?      293           
Flag Coverage Δ
unit 64.77% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 8, 2024
Copy link

ti-chi-bot bot commented Apr 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xhebox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

ti-chi-bot bot commented Apr 8, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-08 01:26:08.460690135 +0000 UTC m=+839229.988230673: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the approved label Apr 8, 2024
@ti-chi-bot ti-chi-bot bot merged commit d40bfdb into pingcap:main Apr 8, 2024
5 checks passed
@djshow832 djshow832 deleted the cert_pool branch April 8, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants