Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tidb as metastore #544

Merged
merged 7 commits into from
Jan 29, 2019
Merged

Conversation

zhexuany
Copy link
Contributor

@zhexuany zhexuany commented Jan 4, 2019

In this PR, we add a hive-site.xml template which can be used as an example if user wants to store their metastore in tidb. In addition, to make user happy, a doc is also created to teach user how to set tidb up.

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PTAL

docs/how_to_use_tidb_as_metastore_db.md Outdated Show resolved Hide resolved
docs/how_to_use_tidb_as_metastore_db.md Outdated Show resolved Hide resolved
docs/how_to_use_tidb_as_metastore_db.md Outdated Show resolved Hide resolved
docs/how_to_use_tidb_as_metastore_db.md Outdated Show resolved Hide resolved
docs/how_to_use_tidb_as_metastore_db.md Outdated Show resolved Hide resolved
config/hive-site.xml Outdated Show resolved Hide resolved
docs/how_to_use_tidb_as_metastore_db.md Show resolved Hide resolved
docs/how_to_use_tidb_as_metastore_db.md Outdated Show resolved Hide resolved
docs/how_to_use_tidb_as_metastore_db.md Outdated Show resolved Hide resolved
@ilovesoup
Copy link
Contributor

So current TiDB version support direct metastore initialize already?

@zhexuany zhexuany removed the request for review from xiaojingchen January 7, 2019 10:51
@zhexuany
Copy link
Contributor Author

/run-all-tests

@zhexuany
Copy link
Contributor Author

Why tidb after 2.1 release canot be used please refer to pingcap/tidb#8793

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhexuany zhexuany dismissed ilovesoup’s stale review January 29, 2019 06:40

Already addressed.

@zhexuany zhexuany merged commit cec026f into pingcap:master Jan 29, 2019
@zhexuany zhexuany deleted the use_tidb_as_metastore branch January 29, 2019 06:40
wfxxh pushed a commit to wanfangdata/tispark that referenced this pull request Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants