Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temperature in Kelvin or Centigrade? #102

Open
raghu1121 opened this issue Feb 16, 2019 · 1 comment
Open

Temperature in Kelvin or Centigrade? #102

raghu1121 opened this issue Feb 16, 2019 · 1 comment
Labels
help wanted

Comments

@raghu1121
Copy link
Contributor

Hi everyone,

Some functions like get_altitude and get_refraction_correction need temperature, but it is not clear from the API if they should be in K or C. Similarly with pressure. I observed that there is no transformation to Kelvin happening in the code. So, I presume the values are needed in Kelvin and Pascal. Please correct me if I am wrong.
It would be great if someone clearly defines that in the documentation of the APIs.

Thanks,
Raghu
@pingswept
Copy link
Owner

Yes, that would be an improvement. Patches welcome.

@pingswept pingswept reopened this Feb 22, 2019
w00kie added a commit to w00kie/pysolar that referenced this issue Jan 23, 2021
@w00kie
Temperature parameters expect Kelvin
81ad641 
Documents temperature parameters in functions as expecting Kelvin.

Referring issue pingswept#102
@w00kie w00kie mentioned this issue Jan 23, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pingswept @raghu1121