Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix validator #60

Merged
merged 4 commits into from
Feb 23, 2024
Merged

Fix validator #60

merged 4 commits into from
Feb 23, 2024

Conversation

WackerO
Copy link
Collaborator

@WackerO WackerO commented Jan 18, 2024

I randomly noticed a little bug in the validator where feature_id_col is used instead of pval_col

pinin4fjords
pinin4fjords approved these changes Jan 22, 2024
View reviewed changes
Copy link
Owner

@pinin4fjords pinin4fjords left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

@WackerO WackerO merged commit 2ae21b4 into pinin4fjords:develop Feb 23, 2024
1 check passed
@WackerO WackerO deleted the fix_validate branch February 23, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinin4fjords pinin4fjords pinin4fjords approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WackerO @pinin4fjords