Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the PCA #63

Merged
merged 2 commits into from
May 1, 2024
Merged

Fix the PCA #63

merged 2 commits into from
May 1, 2024

Conversation

pinin4fjords
Copy link
Owner

I noticed that the PCA execution in exploratory_plots.R has become broken (not quite sure how).

We need to pass the n_genes input through correctly, and also fix the conditionality in the compilePCAData() routine.

@pinin4fjords pinin4fjords merged commit 8e136ce into develop May 1, 2024
1 check passed
@pinin4fjords pinin4fjords deleted the fix_exploratory_pca branch May 1, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WackerO WackerO WackerO approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pinin4fjords @WackerO