Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image lightbox width and post pagination issues #499

Merged
merged 2 commits into from
Aug 14, 2024

Conversation

steven-fox
Copy link
Collaborator

@steven-fox steven-fox commented Aug 8, 2024

This PR fixes:

  • Modal width for tall content.
  • Lightbox images becoming taller than the viewport.
  • Missing click handlers for questions that are fetched via infinite scrolling, as they were added to the DOM after the initial Alpine component init() function ran, so the new ones from the server never added event handlers.

Closes #446

This PR replaces #489. Had something weird happen with the branch/commits when I rebased against main. Check out that PR for more info on this implementation if needed.

Before
image

After
image

pinkary.lightbox.fix.mp4

@nunomaduro nunomaduro merged commit 07f2af6 into main Aug 14, 2024
@nunomaduro nunomaduro deleted the fix/446-lightbox-issues branch August 14, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Enlarge image when clicking on it
2 participants