Refactor: email commands #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrPunyapal
force-pushed
the
refactor/email-commands
branch
from
4e27163
to
3a9cbc3
Compare
nunomaduro
requested changes
Sep 3, 2024
| use Illuminate\Database\Eloquent\Builder; | ||
| use Illuminate\Support\Facades\Mail; | ||
|
|
||
| final class SendReminderEmailsCommand extends Command |
There was a problem hiding this comment.
Feels that this should not be called "reminder".
There was a problem hiding this comment.
SendUnreadNotificationEmailsCommand?
There was a problem hiding this comment.
@CamKem any suggestions?
…ers daily and weekly
…notifications count in email subject and content
MrPunyapal
force-pushed
the
refactor/email-commands
branch
from
3a9cbc3
to
48477cc
Compare
This was
linked to
issues
Sep 12, 2024
…unread-notifications-emails'
nunomaduro
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
SendDailyEmailsCommandandSendWeeklyEmailsCommandin theSendReminderEmailsCommandwith the--weeklyflag.Tests are the same just moved to a new file
SendReminderEmailsCommandTest.-- Solved notifications count issue.
-- Solved logo issue in email