Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for messageFormat strings containing conditionals #442

Merged
merged 7 commits into from
Jul 25, 2023
Merged

Add support for messageFormat strings containing conditionals #442

merged 7 commits into from
Jul 25, 2023

Commits on Jul 23, 2023

  1. Add working happy path for if / end block conditions

    @timlohse1104
    timlohse1104 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    39feab1 View commit details
    Browse the repository at this point in the history

  2. Refactor parsing of messageFormat conditionals in a separate function

    @timlohse1104
    timlohse1104 committed Jul 23, 2023
    Configuration menu
    Copy the full SHA
    2acc0fe View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Add documentation for conditions in readme, add matching between cond… 

    …ition and property key and add further unit tests for parseMessageFormat function
    @timlohse1104
    timlohse1104 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    78578c5 View commit details
    Browse the repository at this point in the history

  2. Update docs of messageFormat with more fitting example 

    Co-authored-by: Matteo Collina <[email protected]>
    @timlohse1104 @mcollina
    timlohse1104 and mcollina authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    b6894c6 View commit details
    Browse the repository at this point in the history

  3. Renamed parseMessageFormat into interpretConditionals, add further in… 

    …teral unit test scenario, refactored interpretConditionals logic to be more readable and renamed internal unit tests to be more fitting
    @timlohse1104
    timlohse1104 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    8f22437 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:timlohse1104/pino-pretty

    @timlohse1104
    timlohse1104 committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    25eab67 View commit details
    Browse the repository at this point in the history

  5. Renamed comments to be more fitting 

    Co-authored-by: James Sumners <[email protected]>
    @timlohse1104 @jsumners
    timlohse1104 and jsumners authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    44ac4c3 View commit details
    Browse the repository at this point in the history