Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolves #85 introduce onBeforeDataWrite callback #87

Merged
merged 1 commit into from
Aug 6, 2022
Merged

resolves #85 introduce onBeforeDataWrite callback #87

merged 1 commit into from
Aug 6, 2022

Conversation

theogravity
Copy link
Contributor

I'm introducing a callback called onBeforeDataWrite with a signature (data: Buffer) => Buffer that allows manipulation of the data before it is written out to the socket.

This resolves #85.

mcollina
mcollina approved these changes Aug 6, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9f87e76 into pinojs:master Aug 6, 2022
@theogravity theogravity deleted the on-before-data-write branch August 7, 2022 02:20
@theogravity theogravity mentioned this pull request Aug 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Callback to manipulate the message before send?
2 participants
@theogravity @mcollina