adding asString to the key (#1779)

pinojs · Aug 10, 2023 · da75c01 · da75c01
1 parent 4c779a4
commit da75c01
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/tools.js b/lib/tools.js
@@ -156,7 +156,8 @@ function asJson (obj, msg, num, time) {
           value = (stringifier || stringify)(value, stringifySafe)
       }
       if (value === undefined) continue
-      propStr += ',"' + key + '":' + value
+      const strKey = asString(key)
+      propStr += ',' + strKey + ':' + value
     }
   }
 

diff --git a/test/basic.test.js b/test/basic.test.js
@@ -420,6 +420,23 @@ test('correctly escape msg strings with unclosed double quote', async ({ same })
   })
 })
 
+test('correctly escape quote in a key', async ({ same }) => {
+  const stream = sink()
+  const instance = pino(stream)
+  const obj = { 'some"obj': 'world' }
+  instance.info(obj, 'a string')
+  const result = await once(stream, 'data')
+  delete result.time
+  same(result, {
+    level: 30,
+    pid,
+    hostname,
+    msg: 'a string',
+    'some"obj': 'world'
+  })
+  same(Object.keys(obj), ['some"obj'])
+})
+
 // https://github.com/pinojs/pino/issues/139
 test('object and format string', async ({ same }) => {
   const stream = sink()