[#84] Fix pinpoint-hbase connection configurations

[cwJohnPark]

Fix pinpoint-hbase/docker-compose.yml and pinpoint-hbase/hbase-site.xml

The pinpoint-hbase container network should be on the pinpoint-zookeeper container bridge network.

hbase.regionserver.hostname should be localhost, hbase.regionserver.ipc.address and hbase.master.ipc.address should be 0.0.0.0 to connect region server in the docker container.

close #84
close #83

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

cwJohnPark seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[RoySRose]

Please review my comments. Let me know what you think.

I've not yet decided if this should be separated into another folder for automated upload to DockerHub.
I need to check a few more things for this. I'll let you know.

[RoySRose]

how about also changing 60000 to 16000 and all the code below that is related (https://hbase.apache.org/book.html#hbase_default_configurations)

[cwJohnPark]

yes, I think that is more related to the others.

[RoySRose]

if it's stand-alone mode. this should be removed

[cwJohnPark]

It is necessary, otherwise region server ipc port will be randomized whenever the hbase container runs.

[RoySRose]

why does region server ipc port not be randomized?

[cwJohnPark]

The pinpoint collector should connect to hbase region server ipc.
I found a similar problem on stackoverflow.

https://stackoverflow.com/questions/43524733/how-to-specify-rpc-server-port-for-hbase

[RoySRose]

if it's stand-alone mode. Is this even necessary? At least, zoo1 is not the zookeeper hbase needs to connect. It should be the internal one.

[cwJohnPark]

It would be obsolete, I just want to use the same yaml file in pinpoint-zookeeper directory.

[RoySRose]

I think you are misunderstading the architecture of stand-alone hbase.

[RoySRose]

Is this necessary when the hbase is in stand-alone mode?

[cwJohnPark]

I think it is.
In order to pinpoint collector and web module that run in host need to know ipc address to connect hbase in docker container.

I had a wrong choice on the word 'stand-alone'.
It is more related to docker container not the hbase itself.

[RoySRose]

If you are using not referring to stand-alone hbase. What is this docker file for?

[cwJohnPark]

This is for the one runs pinpoint collector and web module in IDE or host environment, and want to run hbase as container. because running with hbase binary is too troublesome.

[RoySRose]

@cwJohnPark

I've understood your intentions. But with the below configuration, this will ONLY work IF HBase is on localhost.

<property>
        <name>hbase.regionserver.hostname</name>
        <value>localhost</value>
</property>

Actually there is a solution for below

This is for the one runs pinpoint collector and web module in IDE or host environment
should be taken care of by adding the hbase containers IP address in the host file.

I know adding a line in the host file may be annoying. But since the reason for this is due to the networking architecture of docker containers. I couldn't find any appropriate solution for this yet.
Please let me know what you think about this, and welcome if there is any better solution.

[RoySRose]

@cwJohnPark any updates? or explanation of what the new image is trying to achieve?