Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#11265] Improve logging of StreamObserver.onError #11270

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jul 18, 2024

No description provided.

@emeroad emeroad added this to the 3.0.1 milestone Jul 18, 2024
@emeroad emeroad linked an issue Jul 18, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 36.23188% with 44 lines in your changes missing coverage. Please review.

Project coverage is 36.96%. Comparing base (b418b2b) to head (30833bb).

Files Patch % Lines
...altime/collector/receiver/EmptyCommandService.java 0.00% 10 Missing ⚠️
...om/navercorp/pinpoint/grpc/MessageFormatUtils.java 30.76% 9 Missing ⚠️
...filer/sender/grpc/RetryResponseStreamObserver.java 37.50% 4 Missing and 1 partial ⚠️
.../collector/receiver/grpc/service/AgentService.java 0.00% 4 Missing ⚠️
...t/collector/receiver/grpc/service/SpanService.java 0.00% 4 Missing ⚠️
...t/collector/receiver/grpc/service/StatService.java 0.00% 4 Missing ⚠️
...nt/profiler/receiver/grpc/EmptyStreamObserver.java 0.00% 2 Missing ⚠️
...point/log/collector/grpc/LogConnectionHandler.java 0.00% 2 Missing ⚠️
...tor/receiver/grpc/FluxCommandResponseObserver.java 50.00% 1 Missing and 1 partial ⚠️
...me/collector/receiver/grpc/GrpcCommandService.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #11270      +/-   ##
============================================
+ Coverage     36.92%   36.96%   +0.03%     
- Complexity    12056    12069      +13     
============================================
  Files          4000     4000              
  Lines         98136    98142       +6     
  Branches      10419    10416       -3     
============================================
+ Hits          36237    36277      +40     
+ Misses        58929    58904      -25     
+ Partials       2970     2961       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit 0001341 into pinpoint-apm:master Jul 18, 2024
2 of 3 checks passed
@emeroad emeroad deleted the #11265_onError branch July 19, 2024 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing metadata trailer in StatusErrors
1 participant