-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#11290] Add application logger pattern full-replacement support. #11293
Open
yjqg6666
wants to merge
12
commits into
pinpoint-apm:master
Choose a base branch
from
yjqg6666:logger-replace-pattern-fully
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[#11290] Add application logger pattern full-replacement support. #11293
yjqg6666
wants to merge
12
commits into
pinpoint-apm:master
from
yjqg6666:logger-replace-pattern-fully
+522
−189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 26, 2024
@emeroad This feature has been completed. PTAL. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #11293 +/- ##
============================================
- Coverage 36.92% 36.23% -0.70%
- Complexity 12073 12753 +680
============================================
Files 4011 4159 +148
Lines 98255 106522 +8267
Branches 10416 11535 +1119
============================================
+ Hits 36282 38596 +2314
- Misses 59008 64850 +5842
- Partials 2965 3076 +111 ☔ View full report in Codecov by Sentry. |
yjqg6666
changed the title
Add application logger pattern full-replacement support.
[#11290] Add application logger pattern full-replacement support.
Jul 26, 2024
We plan to review this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #11290.
Automatically change logger's pattern with the configured value.
log4j
profiler.log4j.logging.pattern.replace.enable=true
profiler.log4j.logging.pattern.full_replace.with=TxId:%X{PtxId} %m
log4j2
profiler.log4j2.logging.pattern.replace.enable=true
profiler.log4j2.logging.pattern.full_replace.with=TxId:%X{PtxId} %msg
logback
profiler.logback.logging.pattern.replace.enable=true
profiler.logback.logging.pattern.full_replace.with=%d{yyyy-MM-dd HH:mm:ss} [%p] [%t] %c [Txid:%X{PtxId} ReqId:%X{PreqId}] --- %m%n