Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#8965] Apply SharedTestLifeCycle to plugin test #8969

Merged
merged 7 commits into from
Jun 24, 2022

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Jun 24, 2022

No description provided.

@codecov
Copy link

codecov bot commented Jun 24, 2022

Codecov Report

Merging #8969 (5099252) into master (7890a14) will decrease coverage by 0.01%.
The diff coverage is 37.50%.

@@             Coverage Diff              @@
##             master    #8969      +/-   ##
============================================
- Coverage     39.82%   39.80%   -0.02%     
- Complexity    11827    11833       +6     
============================================
  Files          3351     3353       +2     
  Lines         91076    91136      +60     
  Branches      10084    10093       +9     
============================================
+ Hits          36267    36280      +13     
- Misses        51709    51748      +39     
- Partials       3100     3108       +8     
Impacted Files Coverage Δ
...t/test/plugin/shared/SharedPinpointPluginTest.java 0.00% <0.00%> (ø)
...test/plugin/shared/SharedTestLifeCycleWrapper.java 22.22% <22.22%> (ø)
...npoint/test/plugin/shared/ExecuteSharedThread.java 58.69% <23.52%> (-7.54%) ⬇️
...test/plugin/shared/SharedTestBeforeAllInvoker.java 88.88% <88.88%> (ø)
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...om/navercorp/pinpoint/rpc/codec/PacketDecoder.java 51.66% <0.00%> (-1.67%) ⬇️
...ollector/cluster/zookeeper/ZookeeperJobWorker.java 76.47% <0.00%> (-1.61%) ⬇️
...rc/main/java/com/navercorp/pinpoint/test/Item.java 72.22% <0.00%> (ø)
...tor/metric/datasource/DefaultDataSourceMetric.java 88.88% <0.00%> (+3.70%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fd59aa...5099252. Read the comment docs.

@emeroad emeroad merged commit f884324 into pinpoint-apm:master Jun 24, 2022
@emeroad emeroad linked an issue Jun 30, 2022 that may be closed by this pull request
@emeroad emeroad added this to the 2.5.0 milestone Dec 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SharedTestLifeCycle to simplify plugin integration tests
1 participant