Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Modified QueryParameter class to use the builder pattern #9743

Merged

Conversation

intr3p1d
Copy link
Contributor

@intr3p1d intr3p1d commented Mar 3, 2023

No description provided.

@intr3p1d intr3p1d self-assigned this Mar 3, 2023
@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

Merging #9743 (d8745bd) into master (b1af639) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9743      +/-   ##
============================================
- Coverage     38.81%   38.81%   -0.01%     
- Complexity    11913    11916       +3     
============================================
  Files          3511     3511              
  Lines         94070    94071       +1     
  Branches      10530    10530              
============================================
- Hits          36517    36514       -3     
- Misses        54379    54383       +4     
  Partials       3174     3174              
Impacted Files Coverage Δ
...inpoint/metric/web/util/MetricsQueryParameter.java 0.00% <0.00%> (ø)
...rcorp/pinpoint/metric/web/util/QueryParameter.java 0.00% <0.00%> (ø)
...pinpoint/rpc/ChannelWriteFailListenableFuture.java 42.85% <0.00%> (-28.58%) ⬇️
...p/pinpoint/rpc/stream/StreamChannelRepository.java 57.89% <0.00%> (-21.06%) ⬇️
...vercorp/pinpoint/rpc/packet/ServerClosePacket.java 47.82% <0.00%> (-17.40%) ⬇️
...nitor/DefaultDataSourceMonitorRegistryService.java 72.41% <0.00%> (-10.35%) ⬇️
...rp/pinpoint/rpc/server/PinpointServerAcceptor.java 84.10% <0.00%> (-4.64%) ⬇️
...java/com/navercorp/pinpoint/rpc/DefaultFuture.java 74.31% <0.00%> (-1.84%) ⬇️
...pinpoint/profiler/monitor/DeadlockMonitorTask.java 20.45% <0.00%> (-1.14%) ⬇️
... and 10 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@ga-ram ga-ram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@intr3p1d intr3p1d merged commit c63e923 into pinpoint-apm:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants