Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9760] Move setting kafka endpoint address to FetchResponseInterceptor #9761

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

ga-ram
Copy link
Contributor

@ga-ram ga-ram commented Mar 8, 2023

No description provided.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #9761 (97cce65) into master (4dbf95d) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master    #9761      +/-   ##
============================================
- Coverage     38.81%   38.80%   -0.02%     
+ Complexity    11920    11918       -2     
============================================
  Files          3514     3512       -2     
  Lines         94079    94094      +15     
  Branches      10529    10533       +4     
============================================
- Hits          36519    36514       -5     
- Misses        54386    54406      +20     
  Partials       3174     3174              
Impacted Files Coverage Δ
...m/navercorp/pinpoint/plugin/kafka/KafkaPlugin.java 0.00% <0.00%> (ø)
...in/kafka/interceptor/FetchResponseInterceptor.java 0.00% <0.00%> (ø)
...afka/interceptor/NetworkClientPollInterceptor.java 0.00% <0.00%> (ø)

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ga-ram ga-ram changed the title [#9760] Fix side effects of Kafka3ResponseDataProvider.getResponseData [#9760] Move setting kafka endpoint address to FetchResponseInterceptor Mar 10, 2023
@ga-ram ga-ram requested a review from emeroad March 13, 2023 01:48
@ga-ram ga-ram merged commit 5d40983 into pinpoint-apm:master Mar 13, 2023
@ga-ram ga-ram deleted the 9760 branch March 13, 2023 06:19
@ga-ram ga-ram linked an issue Apr 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinpoint v2.4.2 ~ v2.5.0 kafka plugin bugs on kafka v3.1.0+
1 participant