New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor memqbroker classes #286

Open

Abhiram98 wants to merge 2 commits into pinterest:master from Abhiram98:refactor-memqbroker

Abhiram98 commented Aug 5, 2024 •

edited

Loading

Refactoring changes on top of #272, to split up a couple of large functions, which makes the code easier to follow.

List of changes:
MemqBrokerReplacementAction

extract methods 'waitForHostTermination', 'waitForReplacementHost' from 'runAction'

MemqBrokerDecommissionAction

extract method 'waitForTermination' from 'decommission'.

Abhiram98 added 2 commits

August 4, 2024 17:53


          split long method 'runAction'

bc2bdd4


          split long method 'decomission'

80d8066

Abhiram98 requested a review from a team as a code owner

August 5, 2024 16:41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet