Properly batch Client.set_many() calls #182
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pymemcache.client.base.Client.set_many()
currently loops over itsvalues
dictionary and sends each key-value pair separately rather. This diff drops them in bulk into the fewest TCP packets in which they'll fit. If the overall approach meets your approval, I'll send a separate PR to do the same fordelete_many()
.Using the expanded benchmarks from #180 and snipping output down to just the relevant lines, the current codebase yields these results:
With this diff applied, the results show increased
set_multi
throughput:This has the added side effect of allowing future revisions to add
X_many()
sister methods to any of the other storage commands.