Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow classes, functions, exceptions to be conveniently imported from the package. #197

Merged
merged 6 commits into from
Nov 3, 2018
Merged

Allow classes, functions, exceptions to be conveniently imported from the package. #197

merged 6 commits into from
Nov 3, 2018

Conversation

mainanick
Copy link
Contributor

@mainanick mainanick commented Oct 31, 2018

The PR allows package level import

from pymemcache import Client, PooledClient, MemcacheError, ...

Currently its

from pymemcache.client.base import Client, PooledClient
or 
from pymemcache.client import Client, MemcacheError

@mainanick
Copy link
Contributor Author

Tests seems to fail with a "weird" error
Command "python setup.py egg_info" failed with error code 1. ImportError: No module named six

@nichochar
Copy link
Collaborator

nichochar commented Nov 1, 2018

This is a nice quality of life change, I'll look into the six error.

Six is a package to help make python2 and python3 versions compatible, I wonder why it's complaining on this seemingly unrelated change.

Six is specified as a dependency here

I wonder if something happened at the Travis level which lead to this

Copy link
Collaborator

@nichochar nichochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@nichochar nichochar merged commit 87b933f into pinterest:master Nov 3, 2018
@jparise jparise added this to the 2.1.0 milestone Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants