Unreference elements after priority queue Pop #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #264 +/- ##
==========================================
- Coverage 72.56% 72.43% -0.13%
==========================================
Files 79 79
Lines 3648 3653 +5
==========================================
- Hits 2647 2646 -1
- Misses 867 870 +3
- Partials 134 137 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sean-Der
approved these changes
Aug 6, 2024
| @@ -136,3 +139,46 @@ func TestPriorityQueue_Clean(t *testing.T) { | |||
| assert.EqualValues(t, 1, packets.Length()) | |||
| packets.Clear() | |||
| } | |||
|
|
|||
| func TestPriorityQueue_Unreference(t *testing.T) { | |||
There was a problem hiding this comment.
Thank you for writing this test!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes pion/webrtc#2778
cc: @at-wat