Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Packet struct to match RFC format #119

Merged
merged 2 commits into from
May 16, 2021
Merged

Conversation

ffmiruz
Copy link
Contributor

@ffmiruz ffmiruz commented Feb 8, 2021

Refactor Packet struct to match RFC format

Remove PayloadOffset from Header.
Don't keep unnecessary full data bytes inside Packet.
Packet Marshal and Unmarshal method API stay the same.

Fixes #90

This PR do breaking changes as part of v2 plan.
Related to #88 #79

@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #119 (31e5b0c) into master (4e87540) will decrease coverage by 0.16%.
The diff coverage is 94.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   88.97%   88.80%   -0.17%     
==========================================
  Files          13       13              
  Lines         671      670       -1     
==========================================
- Hits          597      595       -2     
- Misses         56       57       +1     
  Partials       18       18              
Flag Coverage Δ
go 88.80% <94.33%> (-0.17%) ⬇️
wasm 88.20% <92.45%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packet.go 85.09% <94.33%> (-0.55%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e87540...31e5b0c. Read the comment docs.

@Sean-Der
Copy link
Member

Sean-Der commented Feb 8, 2021

This LGTM! Nice work @ffmiyo let me comb through and see if we have any other tech debt.

@cameronelliott @aler9 mind helping with reviews also? Sorry my availability is gonna be bad the next few weeks, so need to pull some others in :)

@cameronelliott
Copy link

This LGTM! Nice work @ffmiyo let me comb through and see if we have any other tech debt.

@cameronelliott @aler9 mind helping with reviews also? Sorry my availability is gonna be bad the next few weeks, so need to pull some others in :)

I'll keep an eye out for stuff that I'm able to help with.
@Sean-Der

@aler9
Copy link
Member

aler9 commented Feb 9, 2021

Since

  1. PayloadOffset and Raw are considered needless (Remove Header.PayloadOffset and Packet.Raw #90)
  2. tests are unchanged

It's probably good to go.

@aler9 aler9 force-pushed the match-rfc branch 2 times, most recently from 93c3645 to b7e6b3a Compare May 16, 2021 16:32
aler9 added a commit to ffmiruz/rtp that referenced this pull request May 16, 2021
v2 is needed since pion#119 drops some fields.
aler9 added a commit to ffmiruz/rtp that referenced this pull request May 16, 2021
v2 is needed since pion#119 drops some fields.
aler9 added a commit to ffmiruz/rtp that referenced this pull request May 16, 2021
v2 is needed since pion#119 drops some fields.
ffmiruz and others added 2 commits May 16, 2021 18:38
Remove PayloadOffset from Header.
Don't keep unnecessary full data bytes inside Packet.
Packet Marshal and Unmarshal method API stay the same.

Fixes pion#90
v2 is needed since pion#119 drops some fields.
@aler9 aler9 merged commit 863e835 into pion:master May 16, 2021
This was referenced May 16, 2021
@aler9 aler9 mentioned this pull request May 22, 2023
@aler9 aler9 mentioned this pull request Jun 12, 2023
aler9 added a commit to aler9/rtp that referenced this pull request Jul 16, 2023
aler9 added a commit to aler9/rtp that referenced this pull request Jul 16, 2023
aler9 added a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Header.PayloadOffset and Packet.Raw
4 participants