-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Packet struct to match RFC format #119
Conversation
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
==========================================
- Coverage 88.97% 88.80% -0.17%
==========================================
Files 13 13
Lines 671 670 -1
==========================================
- Hits 597 595 -2
- Misses 56 57 +1
Partials 18 18
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
This LGTM! Nice work @ffmiyo let me comb through and see if we have any other tech debt. @cameronelliott @aler9 mind helping with reviews also? Sorry my availability is gonna be bad the next few weeks, so need to pull some others in :) |
I'll keep an eye out for stuff that I'm able to help with. |
Since
It's probably good to go. |
93c3645
to
b7e6b3a
Compare
Refactor Packet struct to match RFC format
Remove PayloadOffset from Header.
Don't keep unnecessary full data bytes inside Packet.
Packet Marshal and Unmarshal method API stay the same.
Fixes #90
This PR do breaking changes as part of v2 plan.
Related to #88 #79