Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ClockRate parameter #160

Merged
merged 1 commit into from
Dec 9, 2021
Merged

Remove unused ClockRate parameter #160

merged 1 commit into from
Dec 9, 2021

Conversation

kevmo314
Copy link
Contributor

@kevmo314 kevmo314 commented Dec 8, 2021

This parameter doesn't appear to be used anywhere.

@codecov
Copy link

codecov bot commented Dec 8, 2021

Codecov Report

Merging #160 (077be14) into master (9c94cc0) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #160      +/-   ##
==========================================
- Coverage   93.31%   93.30%   -0.01%     
==========================================
  Files          14       14              
  Lines         942      941       -1     
==========================================
- Hits          879      878       -1     
  Misses         45       45              
  Partials       18       18              
Flag Coverage Δ
go 93.30% <ø> (-0.01%) ⬇️
wasm 92.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packetizer.go 80.55% <ø> (-0.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c94cc0...077be14. Read the comment docs.

This parameter doesn't appear to be used anywhere.
Copy link
Member

@at-wat at-wat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me to put it to v2

@kevmo314 kevmo314 merged commit 885dab7 into master Dec 9, 2021
@stv0g stv0g deleted the packetizer branch May 22, 2023 19:07
@aler9 aler9 mentioned this pull request Jun 12, 2023
aler9 added a commit to aler9/rtp that referenced this pull request Jul 16, 2023
aler9 added a commit to aler9/rtp that referenced this pull request Jul 16, 2023
aler9 added a commit to aler9/rtp that referenced this pull request Jul 16, 2023
aler9 added a commit to aler9/rtp that referenced this pull request Jul 16, 2023
aler9 added a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants