Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pkg into codecs/av1 #237

Merged
merged 1 commit into from
Aug 15, 2023
Merged

Move pkg into codecs/av1 #237

merged 1 commit into from
Aug 15, 2023

Conversation

aler9
Copy link
Member

@aler9 aler9 commented Aug 14, 2023

Description

As previously discussed, the pkg directory is not used in Pion projects.

This maintains compatibility with existing code and adds a deprecation notice to the old objects.

Reference issue

Fixes #221

@aler9 aler9 requested review from stv0g and Sean-Der August 14, 2023 19:23
Fixes pion#221

As previously discussed, the pkg directory is not used in Pion projects.
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3fbe548) 87.38% compared to head (7d798b0) 87.38%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #237   +/-   ##
=======================================
  Coverage   87.38%   87.38%           
=======================================
  Files          20       20           
  Lines        1887     1887           
=======================================
  Hits         1649     1649           
  Misses        207      207           
  Partials       31       31           
Flag Coverage Δ
go 87.38% <100.00%> (ø)
wasm 86.80% <95.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
codecs/av1_packet.go 96.59% <ø> (ø)
codecs/av1/frame/av1.go 100.00% <100.00%> (ø)
codecs/av1/obu/leb128.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aler9 aler9 merged commit 67d2b3e into pion:master Aug 15, 2023
15 checks passed
@aler9 aler9 deleted the patch-pkg branch August 15, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Eliminate pkg directory
2 participants