-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add padding support to Packetizer #251
Conversation
@alexpokotilo LGTM! What do you think of different name like I didn't understand the purpose of the function until I read the code. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #251 +/- ##
==========================================
- Coverage 87.50% 86.41% -1.10%
==========================================
Files 20 21 +1
Lines 1873 2156 +283
==========================================
+ Hits 1639 1863 +224
- Misses 204 257 +53
- Partials 30 36 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
To add padding-only samples call GeneratePadding
dc0c4dc
to
1f351cb
Compare
Sean, |
Merged! Thank you so much @alexpokotilo Can I add you to the Pion org? You can create branches and will run tests for you. Would love to work closer together! |
@Sean-Der |
@Sean-Der,
Should I just wait till new rtp tag 1.8.5 released automatically or I need to do something ? |
You are never bothering me! I really appreciate you being involved :) I am sorry I am so slow to respond! Ping me in the Pion Slack that is much lower volume and I will respond instantly. Email/GitHub is hard for me because I get so much it is hard to filter |
To add padding-only samples call GeneratePadding
Description
Sometime for Bandwidth estimation purposes we need to add Padding-only packages to the stream before switching to new rendition. Once this branch merges I will add pull request to add necessary support to TrackLocalStaticSample in webrtc repo.