Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unmarshaling panic vp8 #254

Merged
merged 1 commit into from
Mar 29, 2024
Merged

fix unmarshaling panic vp8 #254

merged 1 commit into from
Mar 29, 2024

Conversation

vfilipchenkov
Copy link
Contributor

panic when unmarshal 0x81, 0x81, 0x94 panic: runtime error: index out of range [3] with length 3

@Sean-Der
Copy link
Member

Thank you so much @vfilipchenkov! When the tests pass I will merge + tag and update pion/webrtc :)

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.26%. Comparing base (a18e24d) to head (e058c3a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #254      +/-   ##
==========================================
+ Coverage   86.25%   86.26%   +0.01%     
==========================================
  Files          22       22              
  Lines        2160     2163       +3     
==========================================
+ Hits         1863     1866       +3     
  Misses        261      261              
  Partials       36       36              
Flag Coverage Δ
go 86.26% <100.00%> (+0.01%) ⬆️
wasm 85.76% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der
Copy link
Member

Can you update your commit message for linter?

Fix out of range access in VP8 Unmarshal

When unmarshaling 0x81, 0x81, 0x94

    panic: runtime error: index out of range [3] with length 3

When unmarshaling 0x81, 0x81, 0x94

    panic: runtime error: index out of range [3] with length 3
@Sean-Der
Copy link
Member

Updated! After this passes will merge :)

@Sean-Der Sean-Der merged commit 14c61dc into pion:master Mar 29, 2024
14 checks passed
robot-piglet pushed a commit to ytsaurus/ytsaurus that referenced this pull request Apr 17, 2024
Refs:

Наш [патч](pion/rtp#254) отлежался в апстриме 2 недели, пора обновиться
7f1bee3f02d020a76999dc1b7cab893e031bc4bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants