make h264 nalu parsing optional #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not a big deal, avoids a couple of allocations for every STAP-A packet.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #268 +/- ##
==========================================
- Coverage 86.21% 86.05% -0.17%
==========================================
Files 22 22
Lines 1734 1742 +8
==========================================
+ Hits 1495 1499 +4
- Misses 203 206 +3
- Partials 36 37 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sean-Der
force-pushed
the
make-h264-nalu-parsing-optional
branch
2 times, most recently
from
83ede2c
to
a6e0563
Compare
SetZeroAllocation enables a higher performance depacketizer, with a reduced feature set. Currently only enabled for H264. By default, the H264Packet.Unmarshal performs reassembly of FU-A NALUs. Not only is this ineficient, it also assumes that no packet reordering or packet loss ever happens.
Sean-Der
force-pushed
the
make-h264-nalu-parsing-optional
branch
from
a6e0563
to
37bc343
Compare
Sean-Der
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #266 and is related to #267.