Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rare SRTP loss decode failure #277

Merged
merged 1 commit into from
Aug 6, 2024

Conversation

kcaffrey
Copy link
Contributor

@kcaffrey kcaffrey commented Aug 6, 2024

As described in https://webrtc-review.googlesource.com/c/src/+/358360 there can be a problem when the sequence number starts near the rollover point and there is packet loss. As linked to in that issue, libsrtp recommends having the starting sequence number be less than 2^15 to avoid that problem.

As described in https://webrtc-review.googlesource.com/c/src/+/358360
there can be a problem when the sequence number starts near the
rollover point and there is packet loss. As linked to in that issue,
libsrtp recommends having the starting sequence number be less than
2^15 to avoid that problem.
@Sean-Der
Copy link
Member

Sean-Der commented Aug 6, 2024

Thank you @kcaffrey merge + tag where ever you need it :)

@kcaffrey kcaffrey merged commit 4aac982 into pion:master Aug 6, 2024
12 checks passed
@kcaffrey kcaffrey deleted the kevin/fix-loss-decode-failure branch August 6, 2024 18:50
@boks1971
Copy link
Contributor

boks1971 commented Aug 6, 2024

Good catch!

@nils-ohlmeier
Copy link

@kcaffrey you beat me to it :-)
I think this is worth releasing a new version, because without this fix you will get random call failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants