Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port copySessionDescription to all examples #2092

Closed
Sean-Der opened this issue Jan 19, 2022 · 0 comments
Closed

Port copySessionDescription to all examples #2092

Sean-Der opened this issue Jan 19, 2022 · 0 comments

Comments

@Sean-Der
Copy link
Member

In 979aefd @ashellunts added a copy session description feature. Instead of requiring that users copy the entire value they can now hit a button. It helps reduce the amount of copy/paste errors.

All jsfiddles need to be updated to include this now.
@Sean-Der Sean-Der added this to the 3.2.0 milestone Jan 23, 2022
r-novel added a commit to r-novel/webrtc that referenced this issue Jan 27, 2022
@r-novel
refs pion#2092; port copySessionDescription to all relevant examples;…
eee00bc 
… tiny fixes codestyle in api.go file;
@r-novel r-novel mentioned this issue Jan 28, 2022
Merged
r-novel added a commit to r-novel/webrtc that referenced this issue Jan 30, 2022
@r-novel
Merge branch 'master' into feature/pion#2092
74fb757
Sean-Der pushed a commit to r-novel/webrtc that referenced this issue Feb 5, 2022
@r-novel @Sean-Der
Update all examples with copySessionDescription
dcf11b7 
copySessionDescription adds a button to all examples that copies the
local Session Description. This makes it easier for users to copy the
values.

Resolves pion#2092
Sean-Der pushed a commit to r-novel/webrtc that referenced this issue Feb 5, 2022
@r-novel @Sean-Der
Update all examples with copySessionDescription
e506050 
copySessionDescription adds a button to all examples that copies the
local Session Description. This makes it easier for users to copy the
values.

Resolves pion#2092
Sean-Der pushed a commit to r-novel/webrtc that referenced this issue Feb 5, 2022
@r-novel @Sean-Der
Update all examples with copySessionDescription
e934fd8 
copySessionDescription adds a button to all examples that copies the
local Session Description. This makes it easier for users to copy the
values.

Resolves pion#2092
boks1971 pushed a commit that referenced this issue Feb 9, 2022
@r-novel @boks1971
Update all examples with copySessionDescription
0049913 
copySessionDescription adds a button to all examples that copies the
local Session Description. This makes it easier for users to copy the
values.

Resolves #2092
daonb pushed a commit to daonb/webrtc that referenced this issue Nov 20, 2022
@r-novel @daonb
Update all examples with copySessionDescription
7019518 
copySessionDescription adds a button to all examples that copies the
local Session Description. This makes it easier for users to copy the
values.

Resolves pion#2092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sean-Der