-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ice trickle support #691
Conversation
Codecov Report
@@ Coverage Diff @@
## master #691 +/- ##
==========================================
- Coverage 77.33% 77.09% -0.24%
==========================================
Files 57 57
Lines 3644 3694 +50
==========================================
+ Hits 2818 2848 +30
- Misses 585 599 +14
- Partials 241 247 +6
Continue to review full report at Codecov.
|
2862e79
to
a04e625
Compare
@trivigy Ok ready for a first pass! It toggles between I moved most of the behavior into Can you try listening to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing if you don't mind addressing. There is inconsistency regarding what SessionDescription
. Previously session description was extracted from CreateOffer()
where it was returned as a struct instance. Now with trickle changes we need to extract it from LocalDescription()
where it is returned as a pointer. This makes things inconsistent.
we need a way to express |
Resolves pion/ice#51 Co-authored-by: Konstantin Itskov <[email protected]>
resolves pion/ice#51