Added types #29
Merged
Added types #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMystikJonas
force-pushed
the
types
branch
2 times, most recently
from
64b30b3
to
fc3ee63
Compare
|
@pionl Rebased |
pionl
reviewed
Jun 9, 2023
|
|
||
| $containerConfigurator->parameters() | ||
| ->set(Option::PARALLEL, false); | ||
| $containerConfigurator->cacheDirectory('/tmp/ecs'); |
There was a problem hiding this comment.
je tohle safe? Ne na každém operačím systému to bude fungovat ne?
| { | ||
| return $this->customField; | ||
| } | ||
|
|
||
| public function toArray(): array | ||
| { | ||
| return $this->customField->jsonSerialize(); | ||
| return $this->customField !== null ? $this->customField->jsonSerialize() : []; |
There was a problem hiding this comment.
$this->customField?->jsonSerialize() ?? [] Použít tuto syntaxi?
| */ | ||
| public function byId($byId) | ||
| public function byId($byId): self |
|
Mergnu, můžeme řešiv dalším MR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #28 and adds type declaration wherever available and removes few unnecessary complications (like global helpers)