Contacts and import orders endpoints #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinMystikJonas
force-pushed
the
endpoints
branch
3 times, most recently
from
8eba7c0
to
a5d05ff
Compare
|
Prosím o rebase :) |
MartinMystikJonas
force-pushed
the
endpoints
branch
from
a6ac160
to
7ef9cac
Compare
|
@pionl rebased |
pionl
reviewed
Jun 22, 2023
| { | ||
| $this->select = $select; | ||
| return $this; | ||
| InvalidFormatException::checkAllowedValues($select, CustomFieldDefinition::SELECT_FIELDS); |
There was a problem hiding this comment.
Nechceš místo overridu (které máme nyní na více implementacích) dát abstraktní funkci která vynutí aby si vrátil seznam povolených select fieldů a v té abstraktní třídě volat ty checky?
There was a problem hiding this comment.
Takhle to bylo řešeno v původní implementaci tak jsme to zachoval, ale je fakt že ta abstraktní fce by asi byla lepší
There was a problem hiding this comment.
Můžeme se změnit v budoucnu :) díky!
|
dej vědět kdy chceme udělat release verzi :) |
|
Asi bych jeste projel ty model tridy a predelal to vsechno na gettery/settery. Jinak to asi pak muzem releasnout. Tuhle verzi uz mam v produkci. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navazuje na #30
Doplněny endpointy pro
/contactsa/import-ordersOpravěné nějaké nefunkční věci
Možnost s CustomField číst options - aktuálně nefungovalo vůbec + doplněný value objekt
Změna logiky JSON -> Model, aby se dal stejný model použít pro write i read.
Trochu pročištěné a opravené testy.