Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: conversation cutoff #222 #218 #223

Merged
merged 1 commit into from
Mar 13, 2024
Merged

fix: conversation cutoff #222 #218 #223

merged 1 commit into from
Mar 13, 2024

Conversation

lugia19
Copy link
Contributor

@lugia19 lugia19 commented Mar 11, 2024

Just a simple fix for the problem that popped up in #222 and #218 (and a small fix to the converted output)

@lugia19 lugia19 changed the title fix: conversion problems listed in #222 fix: conversation cutoff #222 #218 Mar 12, 2024
@pionxzh pionxzh merged commit 56e6cef into pionxzh:master Mar 13, 2024
1 check passed
@pionxzh
Copy link
Owner

pionxzh commented Mar 13, 2024

LGTM. Thank you!

@lugia19 lugia19 deleted the conversion-fix branch March 13, 2024 12:37
@14790897
Copy link
Contributor

what causes this problem?

@pionxzh
Copy link
Owner

pionxzh commented Mar 14, 2024

@14790897 I think it's because the previous statement if (node.message?.author.role === 'system') will also send the empty message to the list, which causes the loop to stop on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants