Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pagination to retrieve image tags from GCR #1354

Closed
pipecd-bot opened this issue Jan 6, 2021 · 4 comments
Closed

Use pagination to retrieve image tags from GCR #1354

pipecd-bot opened this issue Jan 6, 2021 · 4 comments

Comments

@pipecd-bot
Copy link
Collaborator

https://github.com/pipe-cd/pipe/blob/87a5339df3d21d6eae9ef4630c05e7bda004cbe6/pkg/app/piped/imageprovider/gcr/gcr.go#L105-L108

This was created by todo plugin since "TODO:" was found in 87a5339 when #1344 was merged. cc: @nakabonne.
@nakabonne
Copy link
Member

GCR doesn't implement this pagination, mostly for historical reasons. It may be better to look into other solutions for those who care about it.

Ref: google/go-containerregistry#897

@nakabonne
Copy link
Member

For those who have large tags and care about the response size, we just settled on urging them to use the FAKE image provider. So it may be better to remove this TODO comment and just add NOTE on this line and our documentation.

@nghialv
Copy link
Member

nghialv commented Jan 12, 2021

Close this because we have decided to move to EventWatcher.
/close

@pipecd-bot
Copy link
Collaborator Author

LIFE_CYCLE

@nghialv: Closed this issue in response to this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants