Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make commit clickable on the application list page #3441

Merged
merged 2 commits into from
Mar 25, 2022
Merged

Make commit clickable on the application list page #3441

merged 2 commits into from
Mar 25, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented Mar 24, 2022 •
edited by khanhtc1202
Loading

What this PR does / why we need it:
#3310

before after
Screen Shot 2022-03-24 at 20 10 56 Screen Shot 2022-03-24 at 20 09 41

Which issue(s) this PR fixes:

Fixes #3310

Does this PR introduce a user-facing change?:

Make commit clickable on the application list page

@khanhtc1202
Copy link
Member

Nice idea
/lgtm

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 78.28%. This pull request increases coverage by 0.02%.

File Base Head Diff
src/components/deployments-page/deployment-item/index.tsx 76.00% 79.17% +3.17%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 78.28%. This pull request increases coverage by 0.02%.

File Base Head Diff
src/components/deployments-page/deployment-item/index.tsx 76.00% 79.17% +3.17%

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.11%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for javascript is 78.28%. This pull request increases coverage by 0.02%.

File Base Head Diff
src/components/deployments-page/deployment-item/index.tsx 76.00% 79.17% +3.17%

@nghialv
Copy link
Member

nghialv commented Mar 25, 2022

Love this.

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit c8a7347 into master Mar 25, 2022
@pipecd-bot pipecd-bot deleted the enable-commit-link branch March 25, 2022 02:28
@nghialv
Copy link
Member

nghialv commented Mar 25, 2022

@knanao Maybe we should do this in the application detail and deployment detail page too.

@knanao
Copy link
Member Author

knanao commented Mar 25, 2022

@nghialv
I think it's already addressed!
Screen Shot 2022-03-25 at 11 31 00
Screen Shot 2022-03-25 at 11 31 11

@nghialv
Copy link
Member

nghialv commented Mar 25, 2022

Got it. Thank you.

This was referenced Apr 7, 2022
Merged
Merged
@khanhtc1202 khanhtc1202 mentioned this pull request May 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees
No one assigned
Labels
approved area/web size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make commit clickable on the application list page
4 participants
@knanao @khanhtc1202 @pipecd-bot @nghialv