Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update filedb cursor implementation #3459

Merged
merged 1 commit into from
Mar 30, 2022
Merged

Conversation

khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Mar 30, 2022

What this PR does / why we need it:

Currently, in order to use the datastore List interface in models' stores, Iterator.Cursor interface must be implemented (for instance: applicationstore). We're not required filedb to have Cursor implementation for now so this PR change to implementation for it from return error to dummy cursor (empty string).

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

TODO

The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use /todo skip command.

Details

1. Implement cursor for filedb datastore.

// TODO: Implement cursor for filedb datastore.
return "", nil
}

This was created by todo plugin since "TODO:" was found in f935fbc when #3459 was merged. cc: @khanhtc1202.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 34.94%. This pull request increases coverage by 0.03%.

File Function Base Head Diff
pkg/config/control_plane.go ControlPlaneDataStore.UnmarshalJSON 64.29% 60.00% -4.29%
pkg/datastore/filedb/iterator.go Iterator.Next 0.00% 100.00% +100.00%
pkg/app/piped/executor/cloudrun/deploy.go deployExecutor.ensurePromote 0.00% 0.00% +0.00%
pkg/app/piped/executor/cloudrun/rollback.go rollbackExecutor.ensureRollback 0.00% 0.00% +0.00%

@knanao
Copy link
Member

knanao commented Mar 30, 2022

Nice
/lgtm

@nghialv
Copy link
Member

nghialv commented Mar 30, 2022

Got it.

/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants