-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the source code from actions-gh-release repository #3491
Conversation
A Kapetanios build has just been triggered to run docker operations for the following
|
The following files are not gofmt-ed. By commenting dockers/actions/gh/release/comment_test.go--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
{
name: "one release",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
},
@@ -44,10 +44,10 @@
{
name: "multiple releases",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 2",
},
},
dockers/actions/gh/release/release_test.go--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_0",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_1",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_2",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_3",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "breaking-change",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "new-feature",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "notable-change",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "internal-change",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
{
name: "ok",
commits: []Commit{
- Commit{
+ {
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
},
- Commit{
+ {
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
},
- Commit{
+ {
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
},
- Commit{
+ {
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
},
- Commit{
+ {
Subject: "Commit 5 message",
Body: "commit 5",
},
},
config: config,
expected: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
@@ -202,7 +202,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
},
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
},
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
},
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
@@ -372,7 +372,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
},
config: ReleaseConfig{
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "breaking-change",
Title: "Breaking Changes",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "new-feature",
Title: "New Features",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "notable-change",
Title: "Notable Changes",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "internal-change",
Title: "Internal Changes",
},
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - successAn image named actions-gh-release:2.3.3-0c29872 was procuded for reviewing and testing. There is no test to run inside this directory. |
0c29872
to
7070b8c
Compare
A Kapetanios build has just been triggered to run docker operations for the following
|
The following files are not gofmt-ed. By commenting dockers/actions/gh/release/comment_test.go--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
{
name: "one release",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
},
@@ -44,10 +44,10 @@
{
name: "multiple releases",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 2",
},
},
dockers/actions/gh/release/release_test.go--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_0",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_1",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_2",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_3",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "breaking-change",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "new-feature",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "notable-change",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "internal-change",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
{
name: "ok",
commits: []Commit{
- Commit{
+ {
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
},
- Commit{
+ {
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
},
- Commit{
+ {
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
},
- Commit{
+ {
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
},
- Commit{
+ {
Subject: "Commit 5 message",
Body: "commit 5",
},
},
config: config,
expected: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
@@ -202,7 +202,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
},
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
},
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
},
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
@@ -372,7 +372,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
},
config: ReleaseConfig{
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "breaking-change",
Title: "Breaking Changes",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "new-feature",
Title: "New Features",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "notable-change",
Title: "Notable Changes",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "internal-change",
Title: "Internal Changes",
},
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - successAn image named actions-gh-release:2.3.3-7070b8c was procuded for reviewing and testing. There is no test to run inside this directory. |
7070b8c
to
e5a6427
Compare
A Kapetanios build has just been triggered to run docker operations for the following
|
The following files are not gofmt-ed. By commenting dockers/actions/gh/release/comment_test.go--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
{
name: "one release",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
},
@@ -44,10 +44,10 @@
{
name: "multiple releases",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 2",
},
},
dockers/actions/gh/release/release_test.go--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_0",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_1",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_2",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "_category_3",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "breaking-change",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "new-feature",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "notable-change",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
Id: "internal-change",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
{
name: "ok",
commits: []Commit{
- Commit{
+ {
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
},
- Commit{
+ {
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
},
- Commit{
+ {
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
},
- Commit{
+ {
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
},
- Commit{
+ {
Subject: "Commit 5 message",
Body: "commit 5",
},
},
config: config,
expected: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
@@ -202,7 +202,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
},
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
},
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
},
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
@@ -372,7 +372,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
},
config: ReleaseConfig{
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
Id: "breaking-change",
Title: "Breaking Changes",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "new-feature",
Title: "New Features",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "notable-change",
Title: "Notable Changes",
},
- ReleaseCommitCategoryConfig{
+ {
Id: "internal-change",
Title: "Internal Changes",
},
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - successAn image named actions-gh-release:2.3.3-e5a6427 was procuded for reviewing and testing. There is no test to run inside this directory. |
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
) | ||
|
||
func TestMakeCommentBody(t *testing.T) { | ||
// NOTE: Skip this temporarily since this test result is diiffrent on CI and Local env. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A Kapetanios build has just been triggered to run docker operations for the following
|
The following files are not gofmt-ed. By commenting dockers/actions/gh/release/release_test.go--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_0",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_1",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_2",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_3",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "breaking-change",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "new-feature",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "notable-change",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "internal-change",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
{
name: "ok",
commits: []Commit{
- Commit{
+ {
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
},
- Commit{
+ {
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
},
- Commit{
+ {
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
},
- Commit{
+ {
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
},
- Commit{
+ {
Subject: "Commit 5 message",
Body: "commit 5",
},
},
config: config,
expected: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
@@ -202,7 +202,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
},
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
},
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
},
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
@@ -372,7 +372,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
},
config: ReleaseConfig{
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "breaking-change",
Title: "Breaking Changes",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "new-feature",
Title: "New Features",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "notable-change",
Title: "Notable Changes",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "internal-change",
Title: "Internal Changes",
},
|
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - failureAn image named actions-gh-release:2.3.3-6ef9be8 was procuded for reviewing and testing. There is no test to run inside this directory. |
A Kapetanios build has just been triggered to run docker operations for the following
|
The following files are not gofmt-ed. By commenting dockers/actions/gh/release/comment_test.go--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
{
name: "one release",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
},
@@ -44,10 +44,10 @@
{
name: "multiple releases",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 2",
},
},
dockers/actions/gh/release/release_test.go--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_0",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_1",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_2",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_3",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "breaking-change",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "new-feature",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "notable-change",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "internal-change",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
{
name: "ok",
commits: []Commit{
- Commit{
+ {
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
},
- Commit{
+ {
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
},
- Commit{
+ {
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
},
- Commit{
+ {
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
},
- Commit{
+ {
Subject: "Commit 5 message",
Body: "commit 5",
},
},
config: config,
expected: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
@@ -202,7 +202,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
},
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
},
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
},
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
@@ -372,7 +372,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
},
config: ReleaseConfig{
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "breaking-change",
Title: "Breaking Changes",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "new-feature",
Title: "New Features",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "notable-change",
Title: "Notable Changes",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "internal-change",
Title: "Internal Changes",
},
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - successAn image named actions-gh-release:2.3.3-2b8e5d9 was procuded for reviewing and testing. There is no test to run inside this directory. |
A Kapetanios build has just been triggered to run docker operations for the following
|
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - successAn image named actions-gh-release:2.3.4-27e91b3 was procuded for reviewing and testing. There is no test to run inside this directory. |
A Kapetanios build has just been triggered to run docker operations for the following
|
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - successAn image named actions-gh-release:2.3.4-3716fde was procuded for reviewing and testing. There is no test to run inside this directory. |
3716fde
to
d81eb10
Compare
A Kapetanios build has just been triggered to run docker operations for the following
|
The following files are not gofmt-ed. By commenting dockers/actions/gh/release/comment_test.go--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
{
name: "one release",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
},
@@ -44,10 +44,10 @@
{
name: "multiple releases",
proposals: []ReleaseProposal{
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 1",
},
- ReleaseProposal{
+ {
ReleaseNote: "Release note for tag 2",
},
},
dockers/actions/gh/release/release_test.go--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_0",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_1",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_2",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "_category_3",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
},
},
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "breaking-change",
Title: "Breaking Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/breaking-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "new-feature",
Title: "New Features",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/new-feature"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "notable-change",
Title: "Notable Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
Contains: []string{"change-category/notable-change"},
},
},
- ReleaseCommitCategoryConfig{
+ {
ID: "internal-change",
Title: "Internal Changes",
ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
{
name: "ok",
commits: []Commit{
- Commit{
+ {
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
},
- Commit{
+ {
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
},
- Commit{
+ {
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
},
- Commit{
+ {
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
},
- Commit{
+ {
Subject: "Commit 5 message",
Body: "commit 5",
},
},
config: config,
expected: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2\napp/hello",
@@ -202,7 +202,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
},
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
},
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
},
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
Tag: "v0.2.0",
PreTag: "v0.1.0",
Commits: []ReleaseCommit{
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 1 message",
Body: "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
CategoryName: "breaking-change",
ReleaseNote: "Commit 1 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 2 message",
Body: "commit 2",
@@ -372,7 +372,7 @@
CategoryName: "internal-change",
ReleaseNote: "Commit 2 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 3 message",
Body: "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
CategoryName: "notable-change",
ReleaseNote: "Commit 3 message",
},
- ReleaseCommit{
+ {
Commit: Commit{
Subject: "Commit 4 message",
Body: "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
},
config: ReleaseConfig{
CommitCategories: []ReleaseCommitCategoryConfig{
- ReleaseCommitCategoryConfig{
+ {
ID: "breaking-change",
Title: "Breaking Changes",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "new-feature",
Title: "New Features",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "notable-change",
Title: "Notable Changes",
},
- ReleaseCommitCategoryConfig{
+ {
ID: "internal-change",
Title: "Internal Changes",
},
|
The Kapetanios build to run docker operations for the following 1. dockers/actions-gh-release - successAn image named actions-gh-release:2.3.4-d81eb10 was procuded for reviewing and testing. There is no test to run inside this directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! /lgtm |
here you go |
What this PR does / why we need it:
#3489
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: