Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the source code from actions-gh-release repository #3491

Merged
merged 3 commits into from
Apr 5, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented Apr 5, 2022

What this PR does / why we need it:
#3489

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

dockers/actions/gh/release/comment_test.go
--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
 		{
 			name: "one release",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
 			},
@@ -44,10 +44,10 @@
 		{
 			name: "multiple releases",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 2",
 				},
 			},
dockers/actions/gh/release/release_test.go
--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
 					},
 				},
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_0",
 						Title: "Breaking Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/breaking-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_1",
 						Title: "New Features",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/new-feature"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_2",
 						Title: "Notable Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/notable-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:                         "_category_3",
 						Title:                      "Internal Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
 			},
 		},
 		CommitCategories: []ReleaseCommitCategoryConfig{
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "breaking-change",
 				Title: "Breaking Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/breaking-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "new-feature",
 				Title: "New Features",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/new-feature"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "notable-change",
 				Title: "Notable Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/notable-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:                         "internal-change",
 				Title:                      "Internal Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
 		{
 			name: "ok",
 			commits: []Commit{
-				Commit{
+				{
 					Subject: "Commit 1 message",
 					Body:    "commit 1\napp/hello\n- change-category/breaking-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 2 message",
 					Body:    "commit 2\napp/hello",
 				},
-				Commit{
+				{
 					Subject: "Commit 3 message",
 					Body:    "commit 3\napp/hello\n- change-category/notable-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 4 message",
 					Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
 				},
-				Commit{
+				{
 					Subject: "Commit 5 message",
 					Body:    "commit 5",
 				},
 			},
 			config: config,
 			expected: []ReleaseCommit{
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 1 message",
 						Body:    "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
 					CategoryName: "breaking-change",
 					ReleaseNote:  "Commit 1 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 2 message",
 						Body:    "commit 2\napp/hello",
@@ -202,7 +202,7 @@
 					CategoryName: "internal-change",
 					ReleaseNote:  "Commit 2 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 3 message",
 						Body:    "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
 					CategoryName: "notable-change",
 					ReleaseNote:  "Commit 3 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 4 message",
 						Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
 						},
 						ReleaseNote: "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
 						},
 						ReleaseNote: "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
 						},
 						ReleaseNote: "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
 						CategoryName: "breaking-change",
 						ReleaseNote:  "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
@@ -372,7 +372,7 @@
 						CategoryName: "internal-change",
 						ReleaseNote:  "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
 						CategoryName: "notable-change",
 						ReleaseNote:  "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
 			},
 			config: ReleaseConfig{
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "breaking-change",
 						Title: "Breaking Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "new-feature",
 						Title: "New Features",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "notable-change",
 						Title: "Notable Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "internal-change",
 						Title: "Internal Changes",
 					},

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/release.go Outdated Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - success

An image named actions-gh-release:2.3.3-0c29872 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.3 will be pushed to the container registry.

There is no test to run inside this directory.

@knanao knanao changed the title Move the source code from actions-gh-release repository [WIP] Move the source code from actions-gh-release repository Apr 5, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.45%. This pull request does not change code coverage.

@knanao knanao requested a review from a team as a code owner April 5, 2022 04:34
@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

dockers/actions/gh/release/comment_test.go
--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
 		{
 			name: "one release",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
 			},
@@ -44,10 +44,10 @@
 		{
 			name: "multiple releases",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 2",
 				},
 			},
dockers/actions/gh/release/release_test.go
--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
 					},
 				},
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_0",
 						Title: "Breaking Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/breaking-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_1",
 						Title: "New Features",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/new-feature"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_2",
 						Title: "Notable Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/notable-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:                         "_category_3",
 						Title:                      "Internal Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
 			},
 		},
 		CommitCategories: []ReleaseCommitCategoryConfig{
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "breaking-change",
 				Title: "Breaking Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/breaking-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "new-feature",
 				Title: "New Features",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/new-feature"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "notable-change",
 				Title: "Notable Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/notable-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:                         "internal-change",
 				Title:                      "Internal Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
 		{
 			name: "ok",
 			commits: []Commit{
-				Commit{
+				{
 					Subject: "Commit 1 message",
 					Body:    "commit 1\napp/hello\n- change-category/breaking-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 2 message",
 					Body:    "commit 2\napp/hello",
 				},
-				Commit{
+				{
 					Subject: "Commit 3 message",
 					Body:    "commit 3\napp/hello\n- change-category/notable-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 4 message",
 					Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
 				},
-				Commit{
+				{
 					Subject: "Commit 5 message",
 					Body:    "commit 5",
 				},
 			},
 			config: config,
 			expected: []ReleaseCommit{
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 1 message",
 						Body:    "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
 					CategoryName: "breaking-change",
 					ReleaseNote:  "Commit 1 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 2 message",
 						Body:    "commit 2\napp/hello",
@@ -202,7 +202,7 @@
 					CategoryName: "internal-change",
 					ReleaseNote:  "Commit 2 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 3 message",
 						Body:    "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
 					CategoryName: "notable-change",
 					ReleaseNote:  "Commit 3 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 4 message",
 						Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
 						},
 						ReleaseNote: "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
 						},
 						ReleaseNote: "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
 						},
 						ReleaseNote: "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
 						CategoryName: "breaking-change",
 						ReleaseNote:  "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
@@ -372,7 +372,7 @@
 						CategoryName: "internal-change",
 						ReleaseNote:  "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
 						CategoryName: "notable-change",
 						ReleaseNote:  "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
 			},
 			config: ReleaseConfig{
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "breaking-change",
 						Title: "Breaking Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "new-feature",
 						Title: "New Features",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "notable-change",
 						Title: "Notable Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "internal-change",
 						Title: "Internal Changes",
 					},

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/release.go Outdated Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - success

An image named actions-gh-release:2.3.3-7070b8c was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.3 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

dockers/actions/gh/release/comment_test.go
--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
 		{
 			name: "one release",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
 			},
@@ -44,10 +44,10 @@
 		{
 			name: "multiple releases",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 2",
 				},
 			},
dockers/actions/gh/release/release_test.go
--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
 					},
 				},
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_0",
 						Title: "Breaking Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/breaking-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_1",
 						Title: "New Features",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/new-feature"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "_category_2",
 						Title: "Notable Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/notable-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:                         "_category_3",
 						Title:                      "Internal Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
 			},
 		},
 		CommitCategories: []ReleaseCommitCategoryConfig{
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "breaking-change",
 				Title: "Breaking Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/breaking-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "new-feature",
 				Title: "New Features",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/new-feature"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:    "notable-change",
 				Title: "Notable Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/notable-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				Id:                         "internal-change",
 				Title:                      "Internal Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
 		{
 			name: "ok",
 			commits: []Commit{
-				Commit{
+				{
 					Subject: "Commit 1 message",
 					Body:    "commit 1\napp/hello\n- change-category/breaking-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 2 message",
 					Body:    "commit 2\napp/hello",
 				},
-				Commit{
+				{
 					Subject: "Commit 3 message",
 					Body:    "commit 3\napp/hello\n- change-category/notable-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 4 message",
 					Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
 				},
-				Commit{
+				{
 					Subject: "Commit 5 message",
 					Body:    "commit 5",
 				},
 			},
 			config: config,
 			expected: []ReleaseCommit{
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 1 message",
 						Body:    "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
 					CategoryName: "breaking-change",
 					ReleaseNote:  "Commit 1 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 2 message",
 						Body:    "commit 2\napp/hello",
@@ -202,7 +202,7 @@
 					CategoryName: "internal-change",
 					ReleaseNote:  "Commit 2 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 3 message",
 						Body:    "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
 					CategoryName: "notable-change",
 					ReleaseNote:  "Commit 3 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 4 message",
 						Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
 						},
 						ReleaseNote: "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
 						},
 						ReleaseNote: "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
 						},
 						ReleaseNote: "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
 						CategoryName: "breaking-change",
 						ReleaseNote:  "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
@@ -372,7 +372,7 @@
 						CategoryName: "internal-change",
 						ReleaseNote:  "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
 						CategoryName: "notable-change",
 						ReleaseNote:  "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
 			},
 			config: ReleaseConfig{
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "breaking-change",
 						Title: "Breaking Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "new-feature",
 						Title: "New Features",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "notable-change",
 						Title: "Notable Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						Id:    "internal-change",
 						Title: "Internal Changes",
 					},

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/release.go Outdated Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - success

An image named actions-gh-release:2.3.3-e5a6427 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.3 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.45%. This pull request does not change code coverage.

"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func TestMakeCommentBody(t *testing.T) {
// NOTE: Skip this temporarily since this test result is diiffrent on CI and Local env.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@knanao knanao changed the title [WIP] Move the source code from actions-gh-release repository Move the source code from actions-gh-release repository Apr 5, 2022
@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

dockers/actions/gh/release/release_test.go
--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
 					},
 				},
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_0",
 						Title: "Breaking Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/breaking-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_1",
 						Title: "New Features",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/new-feature"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_2",
 						Title: "Notable Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/notable-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:                         "_category_3",
 						Title:                      "Internal Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
 			},
 		},
 		CommitCategories: []ReleaseCommitCategoryConfig{
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "breaking-change",
 				Title: "Breaking Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/breaking-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "new-feature",
 				Title: "New Features",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/new-feature"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "notable-change",
 				Title: "Notable Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/notable-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:                         "internal-change",
 				Title:                      "Internal Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
 		{
 			name: "ok",
 			commits: []Commit{
-				Commit{
+				{
 					Subject: "Commit 1 message",
 					Body:    "commit 1\napp/hello\n- change-category/breaking-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 2 message",
 					Body:    "commit 2\napp/hello",
 				},
-				Commit{
+				{
 					Subject: "Commit 3 message",
 					Body:    "commit 3\napp/hello\n- change-category/notable-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 4 message",
 					Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
 				},
-				Commit{
+				{
 					Subject: "Commit 5 message",
 					Body:    "commit 5",
 				},
 			},
 			config: config,
 			expected: []ReleaseCommit{
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 1 message",
 						Body:    "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
 					CategoryName: "breaking-change",
 					ReleaseNote:  "Commit 1 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 2 message",
 						Body:    "commit 2\napp/hello",
@@ -202,7 +202,7 @@
 					CategoryName: "internal-change",
 					ReleaseNote:  "Commit 2 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 3 message",
 						Body:    "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
 					CategoryName: "notable-change",
 					ReleaseNote:  "Commit 3 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 4 message",
 						Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
 						},
 						ReleaseNote: "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
 						},
 						ReleaseNote: "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
 						},
 						ReleaseNote: "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
 						CategoryName: "breaking-change",
 						ReleaseNote:  "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
@@ -372,7 +372,7 @@
 						CategoryName: "internal-change",
 						ReleaseNote:  "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
 						CategoryName: "notable-change",
 						ReleaseNote:  "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
 			},
 			config: ReleaseConfig{
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "breaking-change",
 						Title: "Breaking Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "new-feature",
 						Title: "New Features",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "notable-change",
 						Title: "Notable Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "internal-change",
 						Title: "Internal Changes",
 					},

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - failure

An image named actions-gh-release:2.3.3-6ef9be8 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.3 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

dockers/actions/gh/release/comment_test.go
--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
 		{
 			name: "one release",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
 			},
@@ -44,10 +44,10 @@
 		{
 			name: "multiple releases",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 2",
 				},
 			},
dockers/actions/gh/release/release_test.go
--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
 					},
 				},
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_0",
 						Title: "Breaking Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/breaking-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_1",
 						Title: "New Features",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/new-feature"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_2",
 						Title: "Notable Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/notable-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:                         "_category_3",
 						Title:                      "Internal Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
 			},
 		},
 		CommitCategories: []ReleaseCommitCategoryConfig{
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "breaking-change",
 				Title: "Breaking Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/breaking-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "new-feature",
 				Title: "New Features",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/new-feature"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "notable-change",
 				Title: "Notable Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/notable-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:                         "internal-change",
 				Title:                      "Internal Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
 		{
 			name: "ok",
 			commits: []Commit{
-				Commit{
+				{
 					Subject: "Commit 1 message",
 					Body:    "commit 1\napp/hello\n- change-category/breaking-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 2 message",
 					Body:    "commit 2\napp/hello",
 				},
-				Commit{
+				{
 					Subject: "Commit 3 message",
 					Body:    "commit 3\napp/hello\n- change-category/notable-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 4 message",
 					Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
 				},
-				Commit{
+				{
 					Subject: "Commit 5 message",
 					Body:    "commit 5",
 				},
 			},
 			config: config,
 			expected: []ReleaseCommit{
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 1 message",
 						Body:    "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
 					CategoryName: "breaking-change",
 					ReleaseNote:  "Commit 1 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 2 message",
 						Body:    "commit 2\napp/hello",
@@ -202,7 +202,7 @@
 					CategoryName: "internal-change",
 					ReleaseNote:  "Commit 2 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 3 message",
 						Body:    "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
 					CategoryName: "notable-change",
 					ReleaseNote:  "Commit 3 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 4 message",
 						Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
 						},
 						ReleaseNote: "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
 						},
 						ReleaseNote: "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
 						},
 						ReleaseNote: "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
 						CategoryName: "breaking-change",
 						ReleaseNote:  "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
@@ -372,7 +372,7 @@
 						CategoryName: "internal-change",
 						ReleaseNote:  "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
 						CategoryName: "notable-change",
 						ReleaseNote:  "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
 			},
 			config: ReleaseConfig{
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "breaking-change",
 						Title: "Breaking Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "new-feature",
 						Title: "New Features",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "notable-change",
 						Title: "Notable Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "internal-change",
 						Title: "Internal Changes",
 					},

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - success

An image named actions-gh-release:2.3.3-2b8e5d9 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.3 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.45%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - success

An image named actions-gh-release:2.3.4-27e91b3 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.4 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.45%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - success

An image named actions-gh-release:2.3.4-3716fde was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.4 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.45%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. dockers/actions-gh-release

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

dockers/actions/gh/release/comment_test.go
--- dockers/actions-gh-release/comment_test.go.orig
+++ dockers/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
 		{
 			name: "one release",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
 			},
@@ -44,10 +44,10 @@
 		{
 			name: "multiple releases",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 2",
 				},
 			},
dockers/actions/gh/release/release_test.go
--- dockers/actions-gh-release/release_test.go.orig
+++ dockers/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
 					},
 				},
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_0",
 						Title: "Breaking Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/breaking-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_1",
 						Title: "New Features",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/new-feature"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_2",
 						Title: "Notable Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/notable-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:                         "_category_3",
 						Title:                      "Internal Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
 			},
 		},
 		CommitCategories: []ReleaseCommitCategoryConfig{
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "breaking-change",
 				Title: "Breaking Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/breaking-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "new-feature",
 				Title: "New Features",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/new-feature"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "notable-change",
 				Title: "Notable Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/notable-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:                         "internal-change",
 				Title:                      "Internal Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
 		{
 			name: "ok",
 			commits: []Commit{
-				Commit{
+				{
 					Subject: "Commit 1 message",
 					Body:    "commit 1\napp/hello\n- change-category/breaking-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 2 message",
 					Body:    "commit 2\napp/hello",
 				},
-				Commit{
+				{
 					Subject: "Commit 3 message",
 					Body:    "commit 3\napp/hello\n- change-category/notable-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 4 message",
 					Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
 				},
-				Commit{
+				{
 					Subject: "Commit 5 message",
 					Body:    "commit 5",
 				},
 			},
 			config: config,
 			expected: []ReleaseCommit{
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 1 message",
 						Body:    "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
 					CategoryName: "breaking-change",
 					ReleaseNote:  "Commit 1 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 2 message",
 						Body:    "commit 2\napp/hello",
@@ -202,7 +202,7 @@
 					CategoryName: "internal-change",
 					ReleaseNote:  "Commit 2 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 3 message",
 						Body:    "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
 					CategoryName: "notable-change",
 					ReleaseNote:  "Commit 3 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 4 message",
 						Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
 						},
 						ReleaseNote: "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
 						},
 						ReleaseNote: "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
 						},
 						ReleaseNote: "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
 						CategoryName: "breaking-change",
 						ReleaseNote:  "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
@@ -372,7 +372,7 @@
 						CategoryName: "internal-change",
 						ReleaseNote:  "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
 						CategoryName: "notable-change",
 						ReleaseNote:  "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
 			},
 			config: ReleaseConfig{
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "breaking-change",
 						Title: "Breaking Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "new-feature",
 						Title: "New Features",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "notable-change",
 						Title: "Notable Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "internal-change",
 						Title: "Internal Changes",
 					},

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. dockers/actions-gh-release - success

An image named actions-gh-release:2.3.4-d81eb10 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.4 will be pushed to the container registry.

There is no test to run inside this directory.

Copy link
Collaborator

@pipecd-bot pipecd-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GO_LINTER

Some issues were detected while linting go source files in your changes.

dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
dockers/actions-gh-release/github.go Show resolved Hide resolved
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.45%. This pull request does not change code coverage.

@nghialv
Copy link
Member

nghialv commented Apr 5, 2022

Great job!

/lgtm

@pipecd-bot pipecd-bot added the lgtm label Apr 5, 2022
@khanhtc1202
Copy link
Member

here you go
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit e937553 into master Apr 5, 2022
@pipecd-bot pipecd-bot deleted the actions-gh-release branch April 5, 2022 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants