Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename dockers directory to tool #3495

Merged
merged 3 commits into from
Apr 6, 2022
Merged

Rename dockers directory to tool #3495

merged 3 commits into from
Apr 6, 2022

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Apr 6, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 2 directories.
Their results will be reported back after the build is completed.

  1. tool/actions-plan-preview
  2. tool/actions-gh-release

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

tool/actions/gh/release/comment_test.go
--- tool/actions-gh-release/comment_test.go.orig
+++ tool/actions-gh-release/comment_test.go
@@ -35,7 +35,7 @@
 		{
 			name: "one release",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
 			},
@@ -44,10 +44,10 @@
 		{
 			name: "multiple releases",
 			proposals: []ReleaseProposal{
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 1",
 				},
-				ReleaseProposal{
+				{
 					ReleaseNote: "Release note for tag 2",
 				},
 			},
tool/actions/gh/release/release_test.go
--- tool/actions-gh-release/release_test.go.orig
+++ tool/actions-gh-release/release_test.go
@@ -52,28 +52,28 @@
 					},
 				},
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_0",
 						Title: "Breaking Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/breaking-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_1",
 						Title: "New Features",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/new-feature"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "_category_2",
 						Title: "Notable Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 							Contains: []string{"change-category/notable-change"},
 						},
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:                         "_category_3",
 						Title:                      "Internal Changes",
 						ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -115,28 +115,28 @@
 			},
 		},
 		CommitCategories: []ReleaseCommitCategoryConfig{
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "breaking-change",
 				Title: "Breaking Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/breaking-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "new-feature",
 				Title: "New Features",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/new-feature"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:    "notable-change",
 				Title: "Notable Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{
 					Contains: []string{"change-category/notable-change"},
 				},
 			},
-			ReleaseCommitCategoryConfig{
+			{
 				ID:                         "internal-change",
 				Title:                      "Internal Changes",
 				ReleaseCommitMatcherConfig: ReleaseCommitMatcherConfig{},
@@ -163,30 +163,30 @@
 		{
 			name: "ok",
 			commits: []Commit{
-				Commit{
+				{
 					Subject: "Commit 1 message",
 					Body:    "commit 1\napp/hello\n- change-category/breaking-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 2 message",
 					Body:    "commit 2\napp/hello",
 				},
-				Commit{
+				{
 					Subject: "Commit 3 message",
 					Body:    "commit 3\napp/hello\n- change-category/notable-change",
 				},
-				Commit{
+				{
 					Subject: "Commit 4 message",
 					Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
 				},
-				Commit{
+				{
 					Subject: "Commit 5 message",
 					Body:    "commit 5",
 				},
 			},
 			config: config,
 			expected: []ReleaseCommit{
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 1 message",
 						Body:    "commit 1\napp/hello\n- change-category/breaking-change",
@@ -194,7 +194,7 @@
 					CategoryName: "breaking-change",
 					ReleaseNote:  "Commit 1 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 2 message",
 						Body:    "commit 2\napp/hello",
@@ -202,7 +202,7 @@
 					CategoryName: "internal-change",
 					ReleaseNote:  "Commit 2 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 3 message",
 						Body:    "commit 3\napp/hello\n- change-category/notable-change",
@@ -210,7 +210,7 @@
 					CategoryName: "notable-change",
 					ReleaseNote:  "Commit 3 message",
 				},
-				ReleaseCommit{
+				{
 					Commit: Commit{
 						Subject: "Commit 4 message",
 						Body:    "commit 4\napp/hello\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change\n",
@@ -317,28 +317,28 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
 						},
 						ReleaseNote: "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
 						},
 						ReleaseNote: "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
 						},
 						ReleaseNote: "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -356,7 +356,7 @@
 				Tag:    "v0.2.0",
 				PreTag: "v0.1.0",
 				Commits: []ReleaseCommit{
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 1 message",
 							Body:    "commit 1\n- change-category/breaking-change",
@@ -364,7 +364,7 @@
 						CategoryName: "breaking-change",
 						ReleaseNote:  "Commit 1 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 2 message",
 							Body:    "commit 2",
@@ -372,7 +372,7 @@
 						CategoryName: "internal-change",
 						ReleaseNote:  "Commit 2 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 3 message",
 							Body:    "commit 3\n- change-category/notable-change",
@@ -380,7 +380,7 @@
 						CategoryName: "notable-change",
 						ReleaseNote:  "Commit 3 message",
 					},
-					ReleaseCommit{
+					{
 						Commit: Commit{
 							Subject: "Commit 4 message",
 							Body:    "commit 4\n```release-note\nCommit 4 release note\n```\n- change-category/notable-change",
@@ -392,19 +392,19 @@
 			},
 			config: ReleaseConfig{
 				CommitCategories: []ReleaseCommitCategoryConfig{
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "breaking-change",
 						Title: "Breaking Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "new-feature",
 						Title: "New Features",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "notable-change",
 						Title: "Notable Changes",
 					},
-					ReleaseCommitCategoryConfig{
+					{
 						ID:    "internal-change",
 						Title: "Internal Changes",
 					},

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 2 directories has been completed.

1. tool/actions-plan-preview - success

An image named actions-plan-preview:1.7.2-8f60d48 was procuded for reviewing and testing.
By merging this PR, an image named actions-plan-preview:1.7.2 will be pushed to the container registry.

There is no test to run inside this directory.

2. tool/actions-gh-release - success

An image named actions-gh-release:2.3.4-8f60d48 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.4 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. tool/actions-gh-release

@pipecd-bot
Copy link
Collaborator

DOCKER

A Kapetanios build has just been triggered to run docker operations for the following 1 directory.
Their results will be reported back after the build is completed.

  1. tool/actions-gh-release

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. tool/actions-gh-release - scheduled

An image named actions-gh-release:2.3.4-af1c965 was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.4 will be pushed to the container registry.

There is no test to run inside this directory.

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The golinter build is completed with FAILURE. The build will be triggered again when you push any other commits. Or you can trigger it manually by /golinter trigger command right now.

You can check the build log from here.

@pipecd-bot
Copy link
Collaborator

DOCKER

The Kapetanios build to run docker operations for the following 1 directory has been completed.

1. tool/actions-gh-release - success

An image named actions-gh-release:2.3.4-ec409da was procuded for reviewing and testing.
By merging this PR, an image named actions-gh-release:2.3.4 will be pushed to the container registry.

There is no test to run inside this directory.

@knanao
Copy link
Member

knanao commented Apr 6, 2022

Nice
/lgtm

@pipecd-bot pipecd-bot added the lgtm label Apr 6, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.47%. This pull request does not change code coverage.

@khanhtc1202
Copy link
Member

Here you go
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit b30a1aa into master Apr 6, 2022
@pipecd-bot pipecd-bot deleted the dockers branch April 6, 2022 06:01
pipecd-bot pushed a commit that referenced this pull request Apr 7, 2022
**What this PR does / why we need it**:

https://pipecd.dev/docs/user-guide/configuration-reference/#kubernetesdeploymentinput

**Which issue(s) this PR fixes**:

Fixes #3495

**Does this PR introduce a user-facing change?**:

```release-note
NONE
```

This PR was merged by Kapetanios.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants