Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to use IsCompleted instead of IsCompletedDeployment #3519

Merged
merged 1 commit into from
Apr 11, 2022
Merged

Refactor to use IsCompleted instead of IsCompletedDeployment #3519

merged 1 commit into from
Apr 11, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented Apr 11, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@knanao knanao changed the title Refacotr to use IsCompleted insted of IsCompletedDeployment Refacotor to use IsCompleted insted of IsCompletedDeployment Apr 11, 2022
@knanao knanao changed the title Refacotor to use IsCompleted insted of IsCompletedDeployment Refactor to use IsCompleted insted of IsCompletedDeployment Apr 11, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.69%. This pull request increases coverage by 0.05%.

File Function Base Head Diff
pkg/model/deployment.go DeploymentStatus.IsCompleted -- 100.00% +100.00%
pkg/model/deployment.go StageStatus.IsCompleted -- 100.00% +100.00%
pkg/model/deployment.go Deployment.StageMap -- 100.00% +100.00%
pkg/model/deployment.go IsCompletedDeployment 57.14% -- -57.14%
pkg/model/deployment.go IsSuccessfullyCompletedDeployment 0.00% -- +-0.00%
pkg/model/deployment.go IsCompletedStage 0.00% -- +-0.00%
pkg/model/deployment.go Deployment.StageStatusMap 0.00% -- +-0.00%

@nghialv
Copy link
Member

nghialv commented Apr 11, 2022

👍

/lgtm

@knanao knanao changed the title Refactor to use IsCompleted insted of IsCompletedDeployment Refactor to use IsCompleted instead of IsCompletedDeployment Apr 11, 2022
@khanhtc1202
Copy link
Member

Here you go
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@pipecd-bot pipecd-bot merged commit 958746d into master Apr 11, 2022
@pipecd-bot pipecd-bot deleted the model branch April 11, 2022 11:45
@pipecd-bot pipecd-bot mentioned this pull request Apr 12, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

@nghialv nghialv Awaiting requested review from nghialv nghialv is a code owner

Assignees
No one assigned
Labels
approved lgtm release-note-none size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@knanao @pipecd-bot @nghialv @khanhtc1202