Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start publishing helloworld chart to GHCR #3570

Merged
merged 1 commit into from
Apr 22, 2022
Merged

Start publishing helloworld chart to GHCR #3570

merged 1 commit into from
Apr 22, 2022

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Apr 22, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

/approve

@nghialv nghialv requested a review from a team as a code owner April 22, 2022 03:19
@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by nghialv.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv nghialv merged commit afcb9e2 into master Apr 22, 2022
@pipecd-bot pipecd-bot deleted the manifests branch April 22, 2022 03:20
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

@pipecd-bot pipecd-bot mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

@knanao knanao Awaiting requested review from knanao

Assignees
No one assigned
Labels
approved area/manifests release-note-none size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nghialv @pipecd-bot