Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to build frontend without Bazel #3572

Merged
merged 4 commits into from
Apr 22, 2022
Merged

Update to build frontend without Bazel #3572

merged 4 commits into from
Apr 22, 2022

Conversation

nghialv
Copy link
Member

@nghialv nghialv commented Apr 22, 2022

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv nghialv requested a review from a team as a code owner April 22, 2022 06:44
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

1 similar comment
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

@nghialv nghialv changed the title [WIP] Web build Update to build frontend without Bazel Apr 22, 2022
@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

@nghialv
Copy link
Member Author

nghialv commented Apr 22, 2022

web-test fails since the Kapetanios config in the master is still being used.
So please ignore it for now.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

@pipecd-bot
Copy link
Collaborator

COVERAGE

Code coverage for golang is 35.55%. This pull request does not change code coverage.

@knanao
Copy link
Member

knanao commented Apr 22, 2022

Nice!
/lgtm

@khanhtc1202
Copy link
Member

Go bold 👍
/approve

@pipecd-bot
Copy link
Collaborator

APPROVE

This pull request is APPROVED by khanhtc1202.

Approvers can cancel the approval by writing /approve cancel in a comment. Any additional commits also will change this pull request to be not-approved.

@nghialv nghialv merged commit 9c83729 into master Apr 22, 2022
@pipecd-bot pipecd-bot deleted the web-build branch April 22, 2022 08:08
@pipecd-bot pipecd-bot mentioned this pull request May 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knanao knanao knanao left review comments

@khanhtc1202 khanhtc1202 Awaiting requested review from khanhtc1202 khanhtc1202 is a code owner

Assignees
No one assigned
Labels
approved area/kapetanios area/server area/web lgtm release-note-none size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nghialv @pipecd-bot @knanao @khanhtc1202