Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove appconfig commands #3591

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Remove appconfig commands #3591

merged 2 commits into from
Apr 27, 2022

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

Remove pipectl appconfig commands: rename, migrate. Since those commands depend on ListApplications rpc which queries for applications based on EnvName value, but we already removed that logic from this commit
2b64e8a

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@nghialv
Copy link
Member

nghialv commented Apr 27, 2022

Let's update the docs to reflect this remove.

@khanhtc1202
Copy link
Member Author

Let's update the docs to reflect this remove.

Addressed by 8566bd3 🙏

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) April 27, 2022 08:29
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Neats👀

@khanhtc1202 khanhtc1202 merged commit 0fdaffe into master Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants