Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong scrolling css #3621

Merged
merged 1 commit into from
May 11, 2022
Merged

Fix wrong scrolling css #3621

merged 1 commit into from
May 11, 2022

Conversation

khanhtc1202
Copy link
Member

What this PR does / why we need it:

From this

Screen Shot 2022-05-11 at 13 57 39

To this

Screen Shot 2022-05-11 at 13 57 55

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) May 11, 2022 06:59
nghialv
nghialv approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

knanao
knanao approved these changes May 11, 2022
View reviewed changes
Copy link
Member

@knanao knanao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@khanhtc1202 khanhtc1202 merged commit 19a8805 into master May 11, 2022
@khanhtc1202 khanhtc1202 deleted the fix-css branch May 11, 2022 07:13
@nghialv
Copy link
Member

nghialv commented May 11, 2022

/changelog

@pipecd-bot
Copy link
Collaborator

CHANGELOG

@nghialv: Changelog has been generated in response to this comment.

Details

Changelog since v0.30.0

Notable Changes

No notable changes for this release

Internal Changes

  • Fix wrong scrolling css (#3621)
  • Refactor feature status page (#3620)
  • Remove unused code (#3619)
  • Publish launcher-okd image (#3618)
  • Check whether the live manifest exists before deleting the resource (#3615)
  • Fix agent chart to use correct image when starting with launcher (#3616)
  • Add a workflow to ensure the stable docs is being synced (#3617)
  • Revert CloudRun examples to use GCR images (#3614)
  • Fix piped chart to use GHCR container image (#3613)
  • Add get command for the kubectl (#3606)
  • Fix the wrong way to configure datadog key while starting Piped agent (#3611)
  • Update examples to use artifacts from GHCR (#3612)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knanao knanao knanao approved these changes

@nghialv nghialv nghialv approved these changes

Assignees
No one assigned
Labels
area/web release-note-none size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@khanhtc1202 @nghialv @pipecd-bot @knanao