-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add protoc-gen-auth plugin to generate the service.pb.auth.go automatically #3623
Conversation
I think we should not include the plugin binary to this GitHub repository. Instead of that, it should be built by using a multi-stage Dockerfile like this one: |
@nghialv |
No, I meant building it once when making the container image. |
A Kapetanios build has just been triggered to run docker operations for the following
|
The Kapetanios build to run docker operations for the following 1. tool/codegen - successAn image named codegen:0.7.0-ba4eb5f was procuded for reviewing and testing. There is no test to run inside this directory. WARNING: Currently existing container image codegen:0.7.0 will be overridden after merging because this PR did not change the image version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me update tool/codegen version in another PR to avoid including generated file in this PR.
A Kapetanios build has just been triggered to run docker operations for the following
|
The Kapetanios build to run docker operations for the following 1. tool/codegen - successAn image named codegen:0.8.0-a65ddc3 was procuded for reviewing and testing. There is no test to run inside this directory. |
A Kapetanios build has just been triggered to run docker operations for the following
|
The following ISSUES will be created once got merged. If you want me to skip creating the issue, you can use Details1. This way can not parse the first value of enum for some reasons hencepipecd/tool/codegen/protoc-gen-auth/main.go Lines 107 to 110 in 722b591
This was created by todo plugin since "FIXME:" was found in 722b591 when #3623 was merged. cc: @knanao. |
The Kapetanios build to run docker operations for the following 1. tool/codegen - successAn image named codegen:0.8.0-722b591 was procuded for reviewing and testing. There is no test to run inside this directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool 🙌
What this PR does / why we need it:
How to generate auth file
Please add the method option in your proto file like this.
Run make gen/code
You can generate the
.pb.auth.go
file through the make command.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: