-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update codegen version #3629
Update codegen version #3629
Conversation
The following files are not gofmt-ed. By commenting pkg/app/server/service/webservice/service.pb.go--- pkg/app/server/service/webservice/service.pb.go.orig
+++ pkg/app/server/service/webservice/service.pb.go
@@ -21,14 +21,16 @@
package webservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
_ "google.golang.org/protobuf/types/descriptorpb"
wrapperspb "google.golang.org/protobuf/types/known/wrapperspb"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
|
@nghialv |
@knanao It was because we have a list of actions that could be executed. |
The following files are not gofmt-ed. By commenting pkg/app/server/service/webservice/service.pb.go--- pkg/app/server/service/webservice/service.pb.go.orig
+++ pkg/app/server/service/webservice/service.pb.go
@@ -21,14 +21,16 @@
package webservice
import (
+ reflect "reflect"
+ sync "sync"
+
_ "github.com/envoyproxy/protoc-gen-validate/validate"
- model "github.com/pipe-cd/pipecd/pkg/model"
protoreflect "google.golang.org/protobuf/reflect/protoreflect"
protoimpl "google.golang.org/protobuf/runtime/protoimpl"
_ "google.golang.org/protobuf/types/descriptorpb"
wrapperspb "google.golang.org/protobuf/types/known/wrapperspb"
- reflect "reflect"
- sync "sync"
+
+ model "github.com/pipe-cd/pipecd/pkg/model"
)
const (
|
Thank you! Every job is executed. :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Co-authored-by: nghialv <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🙌
What this PR does / why we need it:
UpdateApplicationDescription is removed from service.pb.auth.proto by this PR because this is not implemented.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: