Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update codegen version #3629

Merged
merged 2 commits into from
May 16, 2022
Merged

Update codegen version #3629

merged 2 commits into from
May 16, 2022

Conversation

knanao
Copy link
Member

@knanao knanao commented May 13, 2022

What this PR does / why we need it:
UpdateApplicationDescription is removed from service.pb.auth.proto by this PR because this is not implemented.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

NONE

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/server/service/webservice/service.pb.go
--- pkg/app/server/service/webservice/service.pb.go.orig
+++ pkg/app/server/service/webservice/service.pb.go
@@ -21,14 +21,16 @@
 package webservice
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
-	model "github.com/pipe-cd/pipecd/pkg/model"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
 	_ "google.golang.org/protobuf/types/descriptorpb"
 	wrapperspb "google.golang.org/protobuf/types/known/wrapperspb"
-	reflect "reflect"
-	sync "sync"
+
+	model "github.com/pipe-cd/pipecd/pkg/model"
 )
 
 const (

@knanao
Copy link
Member Author

knanao commented May 13, 2022

@nghialv
I wonder if you could check the permission of github actions from setting page because we cannot run codegen job in new version.
https://github.com/pipe-cd/pipecd/actions/runs/2318686040

@nghialv
Copy link
Member

nghialv commented May 13, 2022

@knanao It was because we have a list of actions that could be executed.
I have just added the new one to that whitelist, so please re-run the workflow.

@pipecd-bot
Copy link
Collaborator

GO_LINTER

The following files are not gofmt-ed. By commenting /golinter fmt, the formatted one will be appended to this pull request automatically.

pkg/app/server/service/webservice/service.pb.go
--- pkg/app/server/service/webservice/service.pb.go.orig
+++ pkg/app/server/service/webservice/service.pb.go
@@ -21,14 +21,16 @@
 package webservice
 
 import (
+	reflect "reflect"
+	sync "sync"
+
 	_ "github.com/envoyproxy/protoc-gen-validate/validate"
-	model "github.com/pipe-cd/pipecd/pkg/model"
 	protoreflect "google.golang.org/protobuf/reflect/protoreflect"
 	protoimpl "google.golang.org/protobuf/runtime/protoimpl"
 	_ "google.golang.org/protobuf/types/descriptorpb"
 	wrapperspb "google.golang.org/protobuf/types/known/wrapperspb"
-	reflect "reflect"
-	sync "sync"
+
+	model "github.com/pipe-cd/pipecd/pkg/model"
 )
 
 const (

@knanao
Copy link
Member Author

knanao commented May 13, 2022

Thank you! Every job is executed. :D

Copy link
Member

@nghialv nghialv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants